Sugar namespsace get. #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #95 +/- ##
==========================================
- Coverage 99.17% 99.16% -0.01%
==========================================
Files 14 14
Lines 362 361 -1
==========================================
- Hits 359 358 -1
Misses 3 3
Continue to review full report at Codecov.
|
starpit
approved these changes
Jan 11, 2018
lib/namespaces.js
Outdated
| let triggers = this.client.request('GET', 'namespaces/_/triggers') | ||
| let rules = this.client.request('GET', 'namespaces/_/rules') | ||
| return Promise | ||
| .all([pactions, packages, triggers, rules]) |
lib/namespaces.js
Outdated
| packages: lists[1], | ||
| triggers: lists[2], | ||
| rules: lists[3] | ||
| })) |
There was a problem hiding this comment.
it may be a bit cleaner here to use the nodejs bind magic?
Promise.all([actions, packages, triggers, rules])
.then(([actions, packages, triggers, rules]) => ({actions, packages, triggers, rules}))
not sure, but maybe?
|
👍 |
csantanapr
approved these changes
Jan 12, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #94.
Due to apache/openwhisk#3167 and apache/openwhisk#3153.