Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove API for listing all entities in namespace #3167

Merged
merged 4 commits into from
Feb 21, 2018
Merged

Remove API for listing all entities in namespace #3167

merged 4 commits into from
Feb 21, 2018

Conversation

rabbah
Copy link
Member

@rabbah rabbah commented Jan 9, 2018 •
edited
Loading

Proposed patch for #3153.

This was referenced Jan 9, 2018
Closed
Merged
@rabbah rabbah force-pushed the wsklist branch 2 times, most recently from 3767528 to 61b97bb Compare January 10, 2018 18:38
@rabbah rabbah mentioned this pull request Jan 11, 2018
Merged
@rabbah rabbah mentioned this pull request Jan 11, 2018
Merged
@rabbah rabbah force-pushed the wsklist branch 4 times, most recently from 189f133 to 3c34608 Compare January 11, 2018 15:56
@rabbah rabbah requested review from dubee and cbickel January 11, 2018 15:57
@rabbah rabbah added API controller review Review for this PR has been requested and yet needs to be done. labels Jan 11, 2018
@rabbah rabbah force-pushed the wsklist branch 3 times, most recently from e6291d8 to 62749c4 Compare January 30, 2018 16:53
@rabbah
Copy link
Member Author

rabbah commented Feb 5, 2018

@csantanapr The node runtimes have been updated, and the CLI as well. I think this is ready then.

@rabbah
Copy link
Member Author

rabbah commented Feb 17, 2018

pg5/104 🏃

@rabbah rabbah added the pgapproved Pipeline has approved this change. label Feb 17, 2018
@csantanapr
Copy link
Member

@cbickel can you review this one when you have chance?

@cbickel
Copy link
Contributor

cbickel commented Feb 20, 2018

In general this PR looks good to me.
But this will be a breaking change in our api, right?
Does this has to be communicated to the community and customers of all the OpenWhisk-installations before we merge it?
And what about the cli command wsk list? Will the CLI make 4 requests instead?

@rabbah
Copy link
Member Author

rabbah commented Feb 20, 2018

@cbickel https://lists.apache.org/thread.html/d49727a3057759bd2879b5b4e37a63e3b6d9b916143f9d315e20d2dc@%3Cdev.openwhisk.apache.org%3E

also I've already updated the CLI and npm openwhisk to sugar the call (and make 4 calls instead).

@mrutkows
Copy link
Contributor

See PR: apache/openwhisk-cli#191
"Handle namespace API listing on the client. #191"

cbickel
cbickel approved these changes Feb 20, 2018
View reviewed changes
Copy link
Contributor

@cbickel cbickel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@csantanapr
Copy link
Member

@cbickel OK to merge this?

@cbickel
Copy link
Contributor

cbickel commented Feb 21, 2018

@csantanapr As you are the only Assignee and not one of the Reviewers, you can decide.

@csantanapr csantanapr merged commit 51e853f into apache:master Feb 21, 2018
chetanmeh added a commit to chetanmeh/incubator-openwhisk that referenced this pull request Apr 6, 2018
@chetanmeh
Remove support for "all" view
16d709d 
Support for "all" view was removed with apache#3167
chetanmeh added a commit to chetanmeh/incubator-openwhisk that referenced this pull request Apr 6, 2018
@chetanmeh
Remove support for "all" view
076bfdb 
Support for "all" view was removed with apache#3167
BillZong pushed a commit to BillZong/openwhisk that referenced this pull request Nov 18, 2019
@rabbah @csantanapr
Remove API for listing all entities in namespace (apache#3167)
de6da7e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cbickel cbickel cbickel approved these changes

@dubee dubee dubee approved these changes

Assignees

@csantanapr csantanapr

Labels
API controller pgapproved Pipeline has approved this change. review Review for this PR has been requested and yet needs to be done.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rabbah @csantanapr @cbickel @mrutkows @dubee