Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-leaf filter operators NULL support. #11185

Merged
merged 1 commit into from
Jul 26, 2023

Conversation

shenyu0127
Copy link
Contributor

This PR includes the following changes:

  • Adds getTrues(), getNulls(), and getFalses() to BaseFilterOperator.
  • Adds NULL support for AndFilterOperator, OrFilterOperator, and NotFilterOperator.

With this PR, when NULL handling is enabled and we have a NOT filter in the query, the query will fail. This is because we are not overriding the getNulls() method in the leaf filter operators.

@codecov-commenter
Copy link

codecov-commenter commented Jul 26, 2023

Codecov Report

Merging #11185 (40c75b0) into master (e87a050) will decrease coverage by 0.01%.
Report is 4 commits behind head on master.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master   #11185      +/-   ##
==========================================
- Coverage    0.11%    0.11%   -0.01%     
==========================================
  Files        2214     2219       +5     
  Lines      118822   119191     +369     
  Branches    17978    18031      +53     
==========================================
  Hits          137      137              
- Misses     118665   119034     +369     
  Partials       20       20              
Flag Coverage Δ
integration1temurin11 0.00% <0.00%> (ø)
integration1temurin17 0.00% <0.00%> (ø)
integration1temurin20 0.00% <0.00%> (?)
integration2temurin11 0.00% <0.00%> (ø)
integration2temurin17 0.00% <0.00%> (?)
integration2temurin20 0.00% <0.00%> (?)
unittests1temurin11 0.00% <0.00%> (ø)
unittests1temurin17 0.00% <0.00%> (ø)
unittests1temurin20 0.00% <0.00%> (ø)
unittests2temurin11 0.11% <0.00%> (-0.01%) ⬇️
unittests2temurin17 0.11% <0.00%> (-0.01%) ⬇️
unittests2temurin20 0.11% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...che/pinot/core/operator/docidsets/AndDocIdSet.java 0.00% <0.00%> (ø)
.../pinot/core/operator/filter/AndFilterOperator.java 0.00% <0.00%> (ø)
...pinot/core/operator/filter/BaseFilterOperator.java 0.00% <0.00%> (ø)
...ore/operator/filter/BitmapBasedFilterOperator.java 0.00% <0.00%> (ø)
...t/core/operator/filter/CombinedFilterOperator.java 0.00% <0.00%> (ø)
...inot/core/operator/filter/EmptyFilterOperator.java 0.00% <0.00%> (ø)
...core/operator/filter/ExpressionFilterOperator.java 0.00% <0.00%> (ø)
...inot/core/operator/filter/FilterOperatorUtils.java 0.00% <0.00%> (ø)
...perator/filter/H3InclusionIndexFilterOperator.java 0.00% <0.00%> (ø)
...ot/core/operator/filter/H3IndexFilterOperator.java 0.00% <0.00%> (ø)
... and 12 more

... and 24 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@shenyu0127 shenyu0127 force-pushed the non-leaf-operators branch 3 times, most recently from d736e26 to 53bb841 Compare July 26, 2023 21:00
@shenyu0127 shenyu0127 force-pushed the non-leaf-operators branch from 53bb841 to 40c75b0 Compare July 26, 2023 21:12
@shenyu0127 shenyu0127 marked this pull request as ready for review July 26, 2023 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants