Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: re-add support for not text_match #12372

Merged
merged 2 commits into from
Feb 22, 2024

Conversation

itschrispeck
Copy link
Collaborator

#11185 incidentally caused a regression with inverse text_match - due to setting _numDocs as 0 in BaseFilterOperator, .getFalses() always returns an empty set. This PR reverts the behavior and allows for not text_match to work again.

tag: bugfix

@codecov-commenter
Copy link

codecov-commenter commented Feb 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5c81c0a) 61.56% compared to head (5e8c1c4) 61.69%.
Report is 14 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #12372      +/-   ##
============================================
+ Coverage     61.56%   61.69%   +0.12%     
- Complexity      201      207       +6     
============================================
  Files          2426     2426              
  Lines        132709   132709              
  Branches      20519    20519              
============================================
+ Hits          81706    81874     +168     
+ Misses        44994    44828     -166     
+ Partials       6009     6007       -2     
Flag Coverage Δ
custom-integration1 <0.01% <0.00%> (?)
integration <0.01% <0.00%> (+<0.01%) ⬆️
integration1 <0.01% <0.00%> (?)
integration2 0.00% <0.00%> (ø)
java-11 61.64% <100.00%> (+61.64%) ⬆️
java-21 61.56% <100.00%> (-0.01%) ⬇️
skip-bytebuffers-false 61.66% <100.00%> (+0.11%) ⬆️
skip-bytebuffers-true 61.54% <100.00%> (+26.71%) ⬆️
temurin 61.69% <100.00%> (+0.12%) ⬆️
unittests 61.68% <100.00%> (+0.12%) ⬆️
unittests1 46.89% <100.00%> (+0.16%) ⬆️
unittests2 27.69% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ankitsultana ankitsultana merged commit 839a91e into apache:master Feb 22, 2024
19 checks passed
@itschrispeck itschrispeck deleted the not_text_match branch February 22, 2024 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants