[Issue 873] Fix flaky test TestRLQMultiTopics() and TestRLQSpecifiedPartitionTopic() #874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gleiphir2769
changed the title
zzzming
reviewed
Oct 28, 2022
| @@ -41,7 +41,7 @@ import ( | |||
|
|
|||
| var ( | |||
| adminURL = "http://localhost:8080" | |||
| lookupURL = "pulsar://localhost:6650" | |||
| lookupURL = "pulsar://10.105.7.225:6650" | |||
There was a problem hiding this comment.
Is this right to change to a fixed private IP? Would that work in CI and other localhost environment?
There was a problem hiding this comment.
I have find the real reason. #875
It's a consumer bug caused by availablePermitsCh.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #873
Motivation
The TestRLQMultiTopics() and TestRLQSpecifiedPartitionTopic() have a very high chance of failing (stuck forever). The purpose of this PR is to fix the stuck problem to save CI cost and find out why it often failed.
In my environment, run the TestRLQMultiTopics() 50 times in a row, the stuck will definitely occur (usually occurs in the tenth). Strangely after changing the location of the DLQ subscription statement, the problem never reappeared.
Did I miss something?
Modifications
The subcription of DLQ consumer has been moved from before RLQ consumer to after RLQ consumer.
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)