Add schema compatibility strategy on topic level #13297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nodece:Thanks for your contribution. For this PR, do we need to update docs? |
|
Hi @nodece please do not delete backticks (for example, |
Anonymitaet
added
doc-required
nodece
force-pushed
the
schema_strategy_topic_level
branch
from
76233bc to
087502c
Compare
codelipenghui
requested review from
315157973,
BewareMyPower,
gaoran10,
hangc0276,
merlimat,
Technoboy- and
codelipenghui
|
@Jason918 Could you please help review this PR? Please make sure the new change follows for enhancement way. |
nodece
force-pushed
the
schema_strategy_topic_level
branch
2 times, most recently
from
c6c25b8 to
d8a84e4
Compare
|
/pulsarbot run-failure-checks |
Jason918
requested changes
Dec 16, 2021
pulsar-client-admin-api/src/main/java/org/apache/pulsar/client/admin/Topics.java
Outdated
Show resolved
Hide resolved
nodece
commented
Dec 16, 2021
pulsar-common/src/main/java/org/apache/pulsar/common/policies/data/TopicPolicies.java
Outdated
Show resolved
Hide resolved
Jason918
reviewed
Dec 17, 2021
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/AbstractTopic.java
Outdated
Show resolved
Hide resolved
pulsar-common/src/main/java/org/apache/pulsar/common/policies/data/TopicPolicies.java
Outdated
Show resolved
Hide resolved
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/AbstractTopic.java
Outdated
Show resolved
Hide resolved
315157973
reviewed
Dec 17, 2021
...r/src/test/java/org/apache/pulsar/schema/compatibility/SchemaTypeCompatibilityCheckTest.java
Outdated
Show resolved
Hide resolved
...r/src/test/java/org/apache/pulsar/schema/compatibility/SchemaTypeCompatibilityCheckTest.java
Outdated
Show resolved
Hide resolved
|
/pulsarbot run-failure-checks |
2 similar comments
|
/pulsarbot run-failure-checks |
|
/pulsarbot run-failure-checks |
Jason918
reviewed
Dec 22, 2021
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java
Outdated
Show resolved
Hide resolved
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/SchemasResourceBase.java
Outdated
Show resolved
Hide resolved
...ava/org/apache/pulsar/schema/compatibility/SchemaTypeCompatibilityCheckOnTopicLevelTest.java
Outdated
Show resolved
Hide resolved
|
/pulsarbot run-failure-checks |
nodece
commented
Dec 22, 2021
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/AdminResource.java
Outdated
Show resolved
Hide resolved
nodece
commented
Dec 22, 2021
...r/src/test/java/org/apache/pulsar/schema/compatibility/SchemaTypeCompatibilityCheckTest.java
Outdated
Show resolved
Hide resolved
nodece
force-pushed
the
schema_strategy_topic_level
branch
from
8c524d5 to
1e26beb
Compare
nodece
force-pushed
the
schema_strategy_topic_level
branch
3 times, most recently
from
24dd4f1 to
1a1d0a5
Compare
1 task
|
/pulsarbot run-failure-checks |
|
@codelipenghui @congbobo184 @Jason918 @315157973 could you take a look this PR? |
Jason918
reviewed
Jan 20, 2022
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/AbstractTopic.java
Outdated
Show resolved
Hide resolved
nodece
force-pushed
the
schema_strategy_topic_level
branch
3 times, most recently
from
42cfa6e to
498f9de
Compare
Anonymitaet
added
doc-complete
nodece
force-pushed
the
schema_strategy_topic_level
branch
2 times, most recently
from
f40705f to
332ad9b
Compare
|
/pulsarbot run-failure-checks |
nodece
force-pushed
the
schema_strategy_topic_level
branch
from
a19abda to
8268c38
Compare
### Motivation Currently, the compatibility strategy for a schema is set at namespace level, which means that all the topics of a namespace will need to adhere to the same compatibility check, this level particle size is relatively large, so add schema compatibility strategy on topic level. ### Modifications - Add set, get and remove schema compatibility strategy API to admin API and client tool - Add schema compatibility strategy action to TopicOperation ### Verifying this change - [x] Make sure that the change passes the CI checks. ### Does this pull request potentially affect one of the following parts: *If `yes` was chosen, please highlight the changes* - Dependencies (does it add or upgrade a dependency): no - The public API: no - The schema: no - The default values of configurations: no - The wire protocol: no - The rest endpoints: no - The admin cli options: no - Anything that affects deployment: no ### Documentation - [x] `doc-required` Signed-off-by: Zixuan Liu <[email protected]>
nodece
force-pushed
the
schema_strategy_topic_level
branch
from
8268c38 to
4053e29
Compare
|
@Jason918 please review again, thanks. |
Jason918
approved these changes
Jan 28, 2022
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Zixuan Liu <[email protected]>
codelipenghui
approved these changes
Jan 28, 2022
This was referenced Jan 28, 2022
1 task
Nicklee007
pushed a commit
to Nicklee007/pulsar
that referenced
this pull request
Apr 20, 2022
### Motivation Currently, the compatibility strategy for a schema is set at namespace level, which means that all the topics of a namespace will need to adhere to the same compatibility check, this level particle size is relatively large, so add schema compatibility strategy on topic level. ### Modifications - Add set, get and remove schema compatibility strategy API to admin API and client tool - Add schema compatibility strategy action to TopicOperation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, the compatibility strategy for a schema is set at namespace level, which means that all the topics of a namespace will need to adhere to the same compatibility check, this level particle size is relatively large, so add schema compatibility strategy on topic level.
Modifications
Verifying this change
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation
Check the box below and label this PR (if you have committer privilege).
Need to update docs?
doc-requiredno-need-docdoc