-
Notifications
You must be signed in to change notification settings - Fork 11.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ISSUE #8380]fix wrong election in controllerMode #8383
base: develop
Are you sure you want to change the base?
[ISSUE #8380]fix wrong election in controllerMode #8383
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #8383 +/- ##
=============================================
- Coverage 43.99% 43.96% -0.03%
+ Complexity 10670 10667 -3
=============================================
Files 1274 1274
Lines 88939 88938 -1
Branches 11432 11431 -1
=============================================
- Hits 39125 39100 -25
- Misses 44854 44871 +17
- Partials 4960 4967 +7 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM~
Thanks for your contributions! |
well, i will add unit test |
…Mode' into fix-wrong-election-in-controllerMode
This reverts commit e9bf0e8.
… code style and unit test
@RongtongJin @lizhimins Please help review the code,thx |
Fixes #8380