Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #8380]fix wrong election in controllerMode #8383

Open
wants to merge 11 commits into
base: develop
Choose a base branch
from

Conversation

Willhow-Gao
Copy link
Contributor

Fixes #8380

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 43.96%. Comparing base (2bc0014) to head (c87eff0).
Report is 2 commits behind head on develop.

Files Patch % Lines
...ntroller/impl/manager/RaftReplicasInfoManager.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #8383      +/-   ##
=============================================
- Coverage      43.99%   43.96%   -0.03%     
+ Complexity     10670    10667       -3     
=============================================
  Files           1274     1274              
  Lines          88939    88938       -1     
  Branches       11432    11431       -1     
=============================================
- Hits           39125    39100      -25     
- Misses         44854    44871      +17     
- Partials        4960     4967       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

TheR1sing3un
TheR1sing3un previously approved these changes Aug 1, 2024
Copy link
Member

@TheR1sing3un TheR1sing3un left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~

@TheR1sing3un
Copy link
Member

Thanks for your contributions!
By the way, how about adding unit tests to cover this code path?

@Willhow-Gao
Copy link
Contributor Author

Thanks for your contributions! By the way, how about adding unit tests to cover this code path?

well, i will add unit test

@TheR1sing3un
Copy link
Member

Thanks for your contributions! By the way, how about adding unit tests to cover this code path?

well, i will add unit test

Great! But could u fix these wrong codestyles in your new code for passing the checks.
image

@Willhow-Gao
Copy link
Contributor Author

Thanks for your contributions! By the way, how about adding unit tests to cover this code path?

well, i will add unit test

Great! But could u fix these wrong codestyles in your new code for passing the checks. image

done

@Willhow-Gao
Copy link
Contributor Author

@RongtongJin @lizhimins Please help review the code,thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] wrong election when using JRaftContorller
3 participants