Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature][Connector-V2][JDBC] Support DB2 Source & Sink #2410

Merged
merged 23 commits into from
Oct 28, 2022
Merged

[Feature][Connector-V2][JDBC] Support DB2 Source & Sink #2410

merged 23 commits into from
Oct 28, 2022

Conversation

laglangyue
Copy link
Contributor

Purpose of this pull request

support connnector-jdbc-v2 DB2
#2367

Check list

@laglangyue laglangyue changed the title [Connector-V2][JDBC-connector] Add more databases that support JDBC：DB2 [Connector-V2][JDBC-connector] support database: DB2 Aug 14, 2022
ashulin
ashulin reviewed Aug 15, 2022
View reviewed changes
pom.xml Outdated Show resolved Hide resolved
@ic4y
Copy link
Contributor

ic4y commented Aug 15, 2022

@laglangyue Wait for the JDBC e2e test (#2321) to merge. You need to add test for DB2 in jdbc e2e test

@laglangyue
Copy link
Contributor Author

@laglangyue Wait for the JDBC e2e test (#2321) to merge. You need to add test for DB2 in jdbc e2e test

yes, the test is very nice. I test in local（laglangyue:jdbc_dm_test），but not quickly .

@laglangyue
Copy link
Contributor Author

this PR may be delay，I am finishing the DM. I spent some time studying the testcontainer，more of environment and DM images.

@CalvinKirs
Copy link
Member

this PR may be delay，I am finishing the DM. I spent some time studying the testcontainer，more of environment and DM images.

take your time

@Hisoka-X Hisoka-X mentioned this pull request Sep 3, 2022
Closed
@Hisoka-X Hisoka-X added the Waiting for users feedback Waiting for feedback from issue/PR author label Sep 5, 2022
ic4y
ic4y reviewed Sep 7, 2022
View reviewed changes
Copy link
Contributor

@ic4y ic4y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modified like a DM connector

pom.xml Outdated Show resolved Hide resolved
@laglangyue laglangyue force-pushed the jdbc_db2 branch 4 times, most recently from 407f406 to 224613f Compare September 18, 2022 03:47
@EricJoy2048
Copy link
Member

Please resolve conflicts.

@laglangyue
Copy link
Contributor Author

Please resolve conflicts.
yes,I will

@ashulin ashulin changed the title [Connector-V2][JDBC-connector] support database: DB2 [Feature][Connector-V2][JDBC] Support DB2 Source & Sink Oct 5, 2022
@EricJoy2048 EricJoy2048 mentioned this pull request Oct 8, 2022
Open
3 tasks
@laglangyue laglangyue force-pushed the jdbc_db2 branch 3 times, most recently from 372e1e0 to 39dd030 Compare October 16, 2022 02:05
@laglangyue
Copy link
Contributor Author

image

DDL DML is finished! And then I execute this Sql, the Connection is Error.

@laglangyue
Copy link
Contributor Author

image

@laglangyue
Copy link
Contributor Author

@ic4y @hailin0 @CalvinKirs I has finiehed the e2e。
There are many problems with the DB2 container. I spent a lot of time studying the disconnection of the DB2 container and SQL compatibility

@EricJoy2048 EricJoy2048 reopened this Oct 26, 2022
ic4y
ic4y approved these changes Oct 28, 2022
View reviewed changes
Copy link
Contributor

@ic4y ic4y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

EricJoy2048
EricJoy2048 approved these changes Oct 28, 2022
View reviewed changes
Copy link
Member

@EricJoy2048 EricJoy2048 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EricJoy2048 EricJoy2048 merged commit bf1ef69 into apache:dev Oct 28, 2022
@hailin0 hailin0 mentioned this pull request Nov 10, 2022
Merged
4 tasks
@laglangyue laglangyue deleted the jdbc_db2 branch February 4, 2023 02:57
@zhilinli123 zhilinli123 mentioned this pull request Apr 11, 2023
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashulin ashulin ashulin left review comments

@CalvinKirs CalvinKirs CalvinKirs left review comments

@hailin0 hailin0 hailin0 left review comments

@ic4y ic4y ic4y approved these changes

@EricJoy2048 EricJoy2048 EricJoy2048 approved these changes

Assignees

@laglangyue laglangyue

Labels
Waiting for users feedback Waiting for feedback from issue/PR author
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@laglangyue @ic4y @CalvinKirs @EricJoy2048 @hailin0 @ashulin @Hisoka-X