Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature][Connector-V2][Teradata] Add Teradata Source And Sink Connector #3362

Merged
merged 3 commits into from
Nov 28, 2022

Conversation

FWLamb
Copy link
Contributor

@FWLamb FWLamb commented Nov 9, 2022

Purpose of this pull request

Refer to #3018
Add Teradata Source And Sink Connector.

Check list

Check list

@FWLamb FWLamb changed the title Connector teradata [Feature][Connector-V2][Teradata] Add Teradata Source And Sink Connector Nov 9, 2022
@FWLamb
Copy link
Contributor Author

FWLamb commented Nov 9, 2022

725ef347a4c95beaae5fcae522e5092

@FWLamb
Copy link
Contributor Author

FWLamb commented Nov 9, 2022

image
image

@TaoZex
Copy link
Contributor

TaoZex commented Nov 10, 2022

Do we need to use jdbc dialect? @hailin0

@hailin0
Copy link
Member

hailin0 commented Nov 10, 2022

Do we need to use jdbc dialect? @hailin0

agree you @TaoZex

@FWLamb reference
#2410

@FWLamb FWLamb marked this pull request as draft November 12, 2022 12:30
@FWLamb FWLamb force-pushed the connector-teradata branch from a2b2b21 to 4b57737 Compare November 13, 2022 09:31
@FWLamb FWLamb marked this pull request as ready for review November 14, 2022 10:46
@FWLamb
Copy link
Contributor Author

FWLamb commented Nov 14, 2022

534f8447470f0e2cf630991ba0009ae

@FWLamb FWLamb force-pushed the connector-teradata branch from a28209b to e2d90be Compare November 15, 2022 02:53
@FWLamb FWLamb force-pushed the connector-teradata branch from 1a50663 to e88d463 Compare November 16, 2022 13:34
TaoZex
TaoZex previously approved these changes Nov 16, 2022
Copy link
Contributor

@TaoZex TaoZex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FWLamb
Copy link
Contributor Author

FWLamb commented Nov 16, 2022

image

@FWLamb
Copy link
Contributor Author

FWLamb commented Nov 16, 2022

@ic4y @hailin0 @EricJoy2048 @TaoZex PTAL.

@FWLamb FWLamb requested a review from ic4y November 16, 2022 14:29
@FWLamb FWLamb closed this Nov 18, 2022
@FWLamb FWLamb force-pushed the connector-teradata branch from 3cbdf68 to ded5481 Compare November 18, 2022 06:11
@FWLamb FWLamb reopened this Nov 18, 2022
@FWLamb FWLamb closed this Nov 18, 2022
@FWLamb FWLamb force-pushed the connector-teradata branch from 9d43606 to 1b406b5 Compare November 18, 2022 09:59
@FWLamb FWLamb reopened this Nov 18, 2022
Comment on lines +52 to +56
public void testTeradata(TestContainer container) throws Exception {
container.executeExtraCommands(extendedFactory);
Container.ExecResult execResult = container.executeJob("/jdbc_teradata_source_and_sink.conf");
Assertions.assertEquals(0, execResult.getExitCode());
clearSinkTable();
Copy link
Member

@hailin0 hailin0 Nov 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Teradata does not have a Docker image, and it seems that it cannot be made by itself.

Copy link
Contributor

@ic4y ic4y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants