Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug][JdbcSink] Set default value to false of JdbcOption: generate_sink_sql #4471

Merged
merged 14 commits into from
Apr 3, 2023
Merged

[Bug][JdbcSink] Set default value to false of JdbcOption: generate_sink_sql #4471

merged 14 commits into from
Apr 3, 2023

Conversation

rewerma
Copy link
Contributor

@rewerma rewerma commented Apr 1, 2023 •
edited
Loading

Purpose of this pull request

Set default value to false of JdbcOption: generate_sink_sql

Check list

@EricJoy2048
Copy link
Member

@ashulin PTAL

@rewerma rewerma changed the title [Bug][JdbcSink] Set default value to false of JdbcPotion: generate_sink_sql [Bug][JdbcSink] Set default value to false of JdbcOption: generate_sink_sql Apr 1, 2023
TyrantLucifer
TyrantLucifer approved these changes Apr 1, 2023
View reviewed changes
Copy link
Member

@TyrantLucifer TyrantLucifer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, cc @hailin0

@TyrantLucifer TyrantLucifer merged commit 7da11c2 into apache:dev Apr 3, 2023
MonsterChenzhuo pushed a commit to MonsterChenzhuo/incubator-seatunnel that referenced this pull request Apr 19, 2023
@rewerma @MonsterChenzhuo
[Hotfix][Connector-V2][Jdbc] Set default value to false of JdbcOption…
3c4cb0e 
…: generate_sink_sql (apache#4471)

* Set default value to false of JdbcPotion: generate_sink_sql

* fix e2e config

---------

Co-authored-by: mcy <[email protected]>
ic4y pushed a commit to ic4y/incubator-seatunnel that referenced this pull request May 22, 2023
@rewerma @EricJoy2048
[Hotfix][Connector-V2][Jdbc] Set default value to false of JdbcOption…
54f4e7b 
…: generate_sink_sql (apache#4471)

* Set default value to false of JdbcPotion: generate_sink_sql

* fix e2e config

---------

Co-authored-by: mcy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TyrantLucifer TyrantLucifer TyrantLucifer approved these changes

@Hisoka-X Hisoka-X Hisoka-X approved these changes

Assignees
No one assigned
Labels
approved reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rewerma @EricJoy2048 @Hisoka-X @TyrantLucifer