Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug][JdbcSink] Set default value to false of JdbcOption: generate_sink_sql #4471

Merged
merged 14 commits into from
Apr 3, 2023
Merged

[Bug][JdbcSink] Set default value to false of JdbcOption: generate_sink_sql #4471

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
17772fc
Merge pull request #1 from apache/dev
rewerma Feb 11, 2023
2d2876e
Merge branch 'apache:dev' into dev
rewerma Feb 14, 2023
ed8df96
Merge branch 'apache:dev' into dev
rewerma Feb 15, 2023
163b7f8
Merge branch 'apache:dev' into dev
rewerma Mar 4, 2023
0477c85
Merge branch 'apache:dev' into dev
rewerma Mar 5, 2023
562cf09
Merge branch 'apache:dev' into dev
rewerma Mar 6, 2023
5405370
Merge branch 'apache:dev' into dev
rewerma Mar 10, 2023
2d6d7d7
Merge branch 'apache:dev' into dev
rewerma Mar 20, 2023
d7852f9
Merge branch 'apache:dev' into dev
rewerma Mar 25, 2023
87fa686
Merge branch 'apache:dev' into dev
rewerma Mar 27, 2023
94e7da6
Merge branch 'apache:dev' into dev
rewerma Mar 30, 2023
7ebafdc
Merge branch 'apache:dev' into dev
rewerma Apr 1, 2023
daae998
Set default value to false of JdbcPotion: generate_sink_sql
Apr 1, 2023
c44dbfa
fix e2e config
rewerma Apr 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/config/JdbcOptions.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ public interface JdbcOptions {
Option<Boolean> GENERATE_SINK_SQL =
Options.key("generate_sink_sql")
.booleanType()
.defaultValue(true)
.defaultValue(false)
.withDescription("generate sql using the database table");

Option<String> XA_DATA_SOURCE_CLASS_NAME =
Expand Down
2 changes: 2 additions & 0 deletions ...nector-v2-e2e/connector-cdc-sqlserver-e2e/src/test/resources/sqlservercdc_to_console.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,8 @@ sink {
url = "jdbc:sqlserver://sqlserver-host:1433;encrypt=false"
user = "sa"
password = "Password!"
generate_sink_sql = true
database = ""
table = "column_type_test.dbo.full_types_sink"
batch_size = 1
primary_keys = ["id"]
Expand Down
2 changes: 1 addition & 1 deletion ...or-jdbc-e2e/connector-jdbc-e2e-part-1/src/test/resources/jdbc_sink_auto_generate_sql.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ sink {
url = "jdbc:postgresql://postgresql:5432/test?loggerLevel=OFF"
user = test
password = test

generate_sink_sql = true
database = test
table = "public.sink"
}
Expand Down
1 change: 1 addition & 0 deletions ...c-e2e/connector-jdbc-e2e-part-1/src/test/resources/jdbc_sink_auto_generate_upsql_sql.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ sink {
url = "jdbc:postgresql://postgresql:5432/test?loggerLevel=OFF"
user = test
password = test
generate_sink_sql = true
database = test
table = "public.sink"
primary_keys = ["user_id"]
Expand Down
1 change: 1 addition & 0 deletions ...nector-jdbc-e2e/connector-jdbc-e2e-part-3/src/test/resources/jdbc_sink_cdc_changelog.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,7 @@ sink {
url = "jdbc:postgresql://postgresql:5432/test?loggerLevel=OFF"
user = test
password = test
generate_sink_sql = true
database = test
table = "public.sink"
primary_keys = ["pk_id"]
Expand Down
1 change: 1 addition & 0 deletions ...nnector-v2-e2e/connector-kafka-e2e/src/test/resources/kafkasource_canal_cdc_to_pgsql.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@ sink {
url = "jdbc:postgresql://postgresql:5432/test?loggerLevel=OFF"
user = test
password = test
generate_sink_sql = true
database = public
table = sink
primary_keys = ["id"]
Expand Down