Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improve][Connector-V2] Change amazonsqs to AmazonSqs as connector identifier #5742

Merged
merged 1 commit into from
Oct 30, 2023

Conversation

Hisoka-X
Copy link
Member

Purpose of this pull request

Uniformly use AmazonSqs instead of amazonsqs as the connector identifier, and add AmazonSqs to the binary package.

Does this PR introduce any user-facing change?

no

How was this patch tested?

exist test.

Check list

@Hisoka-X
Copy link
Member Author

cc @HaoXuAI

@@ -50,7 +50,7 @@ public class AmazonSqsSink extends AbstractSimpleSink<SeaTunnelRow, Void> {

@Override
public String getPluginName() {
return "amazonsqs";
return "AmazonSqs";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it compatible with older versions?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AmazonSqs not released in 2.3.3. PS: our plugin name mapping ignore case.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good

@HaoXuAI
Copy link
Contributor

HaoXuAI commented Oct 28, 2023

thanks!

@hailin0 hailin0 merged commit 245705d into apache:dev Oct 30, 2023
@Hisoka-X Hisoka-X deleted the followup-amazonaqs branch October 30, 2023 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants