Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improve][Connector-V2] Change amazonsqs to AmazonSqs as connector identifier #5742

Merged
merged 1 commit into from
Oct 30, 2023
Merged

[Improve][Connector-V2] Change amazonsqs to AmazonSqs as connector identifier #5742

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/en/connector-v2/sink/AmazonSqs.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ source {
}

sink {
amazonsqs {
AmazonSqs {
url = "http://127.0.0.1:8000"
region = "us-east-1"
queue = "queueName"
Expand Down
2 changes: 1 addition & 1 deletion docs/en/connector-v2/source/AmazonSqs.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ Read data from Amazon SQS.

```bash
source {
amazonsqs {
AmazonSqs {
url = "http://127.0.0.1:4566"
region = "us-east-1"
format = text
Expand Down
2 changes: 1 addition & 1 deletion ...src/main/java/org/apache/seatunnel/connectors/seatunnel/amazonsqs/sink/AmazonSqsSink.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ public class AmazonSqsSink extends AbstractSimpleSink<SeaTunnelRow, Void> {

@Override
public String getPluginName() {
return "amazonsqs";
return "AmazonSqs";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it compatible with older versions?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AmazonSqs not released in 2.3.3. PS: our plugin name mapping ignore case.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good

}

public AmazonSqsSink(ReadonlyConfig pluginConfig, SeaTunnelRowType typeInfo) {
Expand Down
2 changes: 1 addition & 1 deletion ...main/java/org/apache/seatunnel/connectors/seatunnel/amazonsqs/source/AmazonSqsSource.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ public class AmazonSqsSource extends AbstractSingleSplitSource<SeaTunnelRow>

@Override
public String getPluginName() {
return "amazonsqs";
return "AmazonSqs";
}

@Override
Expand Down
7 changes: 7 additions & 0 deletions seatunnel-dist/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -521,6 +521,13 @@
<scope>provided</scope>
</dependency>

<dependency>
<groupId>org.apache.seatunnel</groupId>
<artifactId>connector-amazonsqs</artifactId>
<version>${project.version}</version>
<scope>provided</scope>
</dependency>

<!-- jdbc driver -->
<dependency>
<groupId>com.aliyun.phoenix</groupId>
Expand Down
4 changes: 2 additions & 2 deletions ...nnector-v2-e2e/connector-amazonsqs-e2e/src/test/resources/amazonsqsIT_source_to_sink.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ env {

source {
# This is a example source plugin **only for test and demonstrate the feature source plugin**
amazonsqs {
AmazonSqs {
url = "http://sqs-host:4566/000000000000/source_queue"
access_key_id = "1234"
secret_access_key = "abcd"
Expand All @@ -46,7 +46,7 @@ transform {

sink {
# This is a example source plugin **only for test and demonstrate the feature sink plugin**
amazonsqs {
AmazonSqs {
url = "http://sqs-host:4566/000000000000/sink_queue"
access_key_id = "1234"
secret_access_key = "abcd"
Expand Down