-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Improve][Connector-V2][MongoDB] A BsonInt32 will be convert to a long type #7567
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks @loustler
Hi @loustler , I thinked about it again, is it possible to add a UT to cover the newly added logic? |
Sorry. You are right, unit test. But I think add a e2e test case for this small feature is too heavy. We can add some unit test in https://github.com/apache/seatunnel/tree/e31c9c2a9a0804fd24f3ad16ab28fa4fd7ecc2bb/seatunnel-connectors-v2/connector-mongodb/src/test/java/org/apache/seatunnel/connectors/seatunnel/mongodb . Line 40 in e31c9c2
or Line 65 in e31c9c2
|
You're right. It can be too heavy for this case. I'll added a unit test for it with another PR |
Purpose of this pull request
BsonInt32
can be changed to a long type by itself, so we need to support it.https://github.com/mongodb/mongo-java-driver/blob/525c465df46f791684fccef0a1ba49f72cbba026/bson/src/main/org/bson/BsonInt32.java#L63-L66
Does this PR introduce any user-facing change?
NO
How was this patch tested?
Package the connector-mongo-2.3.7-2.12.15.jar, place it in a docker image, and complete the MongoDB reading test
Check list
New License Guide
release-note
.