Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improve][Test][Connector-V2][MongoDB] Add few test cases for BsonToRowDataConverters #7579

Merged
merged 2 commits into from
Sep 4, 2024

Conversation

loustler
Copy link
Contributor

@loustler loustler commented Sep 4, 2024

Purpose of this pull request

Add few test cases to covered as a unit test for last PR #6997 , #7567. They were improved a BsonToRowDataConverters about a double and a bigint. But I added a test case for #6997 as a e2e test case, now I felt it's too heavy for it, so I changed it to a unit test, and a new test case for #7567

It resolved this discussion

Does this PR introduce any user-facing change?

NO

How was this patch tested?

NO NEED

Check list

@loustler loustler changed the title [Improve][Test][Connector-V2][MongoDB]Add few test cases for BsonToRowDataConverters [Improve][Test][Connector-V2][MongoDB] Add few test cases for BsonToRowDataConverters Sep 4, 2024
Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @loustler !

@hailin0 hailin0 merged commit a797041 into apache:dev Sep 4, 2024
5 checks passed
@loustler loustler deleted the mongodb/ut branch September 4, 2024 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants