Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-18617][Test]Fix flaky test: StreamingContextSuite.SPARK-18560 Receiver data should be deserialized properly #16091

Closed
wants to merge 1 commit into from

Conversation

zsxwing
Copy link
Member

@zsxwing zsxwing commented Dec 1, 2016

What changes were proposed in this pull request?

Fixed the potential SparkContext leak in StreamingContextSuite.SPARK-18560 Receiver data should be deserialized properly which was added in #16052. I also removed FakeByteArrayReceiver and used TestReceiver directly.

How was this patch tested?

Jenkins

@zsxwing
Copy link
Member Author

zsxwing commented Dec 1, 2016

cc @rxin

@rxin
Copy link
Contributor

rxin commented Dec 1, 2016

LGTM

@SparkQA
Copy link

SparkQA commented Dec 1, 2016

Test build #69438 has finished for PR 16091 at commit dc07283.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@rxin
Copy link
Contributor

rxin commented Dec 1, 2016

Merging in master/branch-2.1.

asfgit pushed a commit that referenced this pull request Dec 1, 2016
…e. Receiver data should be deserialized properly

## What changes were proposed in this pull request?

Fixed the potential SparkContext leak in `StreamingContextSuite.SPARK-18560 Receiver data should be deserialized properly` which was added in #16052. I also removed FakeByteArrayReceiver and used TestReceiver directly.

## How was this patch tested?

Jenkins

Author: Shixiong Zhu <[email protected]>

Closes #16091 from zsxwing/SPARK-18617-follow-up.

(cherry picked from commit 0a81121)
Signed-off-by: Reynold Xin <[email protected]>
@asfgit asfgit closed this in 0a81121 Dec 1, 2016
@SparkQA
Copy link

SparkQA commented Dec 1, 2016

Test build #69439 has finished for PR 16091 at commit 4785df8.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

asfgit pushed a commit that referenced this pull request Dec 1, 2016
…e for Spark Streaming

## What changes were proposed in this pull request?

This is a follow-up PR to backport #16052 to branch-2.0 with incremental update in #16091

## How was this patch tested?

new unit test

cc zsxwing rxin

Author: uncleGen <[email protected]>

Closes #16096 from uncleGen/branch-2.0-SPARK-18617.
@zsxwing zsxwing deleted the SPARK-18617-follow-up branch December 1, 2016 19:25
asfgit pushed a commit that referenced this pull request Dec 1, 2016
…te. Receiver data should be deserialized properly

## What changes were proposed in this pull request?

Avoid to create multiple threads to stop StreamingContext. Otherwise, the latch added in #16091 can be passed too early.

## How was this patch tested?

Jenkins

Author: Shixiong Zhu <[email protected]>

Closes #16105 from zsxwing/SPARK-18617-2.

(cherry picked from commit 086b0c8)
Signed-off-by: Shixiong Zhu <[email protected]>
asfgit pushed a commit that referenced this pull request Dec 1, 2016
…te. Receiver data should be deserialized properly

## What changes were proposed in this pull request?

Avoid to create multiple threads to stop StreamingContext. Otherwise, the latch added in #16091 can be passed too early.

## How was this patch tested?

Jenkins

Author: Shixiong Zhu <[email protected]>

Closes #16105 from zsxwing/SPARK-18617-2.

(cherry picked from commit 086b0c8)
Signed-off-by: Shixiong Zhu <[email protected]>
ghost pushed a commit to dbtsai/spark that referenced this pull request Dec 1, 2016
…te. Receiver data should be deserialized properly

## What changes were proposed in this pull request?

Avoid to create multiple threads to stop StreamingContext. Otherwise, the latch added in apache#16091 can be passed too early.

## How was this patch tested?

Jenkins

Author: Shixiong Zhu <[email protected]>

Closes apache#16105 from zsxwing/SPARK-18617-2.
robert3005 pushed a commit to palantir/spark that referenced this pull request Dec 2, 2016
…e. Receiver data should be deserialized properly

## What changes were proposed in this pull request?

Fixed the potential SparkContext leak in `StreamingContextSuite.SPARK-18560 Receiver data should be deserialized properly` which was added in apache#16052. I also removed FakeByteArrayReceiver and used TestReceiver directly.

## How was this patch tested?

Jenkins

Author: Shixiong Zhu <[email protected]>

Closes apache#16091 from zsxwing/SPARK-18617-follow-up.
robert3005 pushed a commit to palantir/spark that referenced this pull request Dec 2, 2016
…te. Receiver data should be deserialized properly

## What changes were proposed in this pull request?

Avoid to create multiple threads to stop StreamingContext. Otherwise, the latch added in apache#16091 can be passed too early.

## How was this patch tested?

Jenkins

Author: Shixiong Zhu <[email protected]>

Closes apache#16105 from zsxwing/SPARK-18617-2.
robert3005 pushed a commit to palantir/spark that referenced this pull request Dec 15, 2016
…e. Receiver data should be deserialized properly

## What changes were proposed in this pull request?

Fixed the potential SparkContext leak in `StreamingContextSuite.SPARK-18560 Receiver data should be deserialized properly` which was added in apache#16052. I also removed FakeByteArrayReceiver and used TestReceiver directly.

## How was this patch tested?

Jenkins

Author: Shixiong Zhu <[email protected]>

Closes apache#16091 from zsxwing/SPARK-18617-follow-up.
uzadude pushed a commit to uzadude/spark that referenced this pull request Jan 27, 2017
…e. Receiver data should be deserialized properly

## What changes were proposed in this pull request?

Fixed the potential SparkContext leak in `StreamingContextSuite.SPARK-18560 Receiver data should be deserialized properly` which was added in apache#16052. I also removed FakeByteArrayReceiver and used TestReceiver directly.

## How was this patch tested?

Jenkins

Author: Shixiong Zhu <[email protected]>

Closes apache#16091 from zsxwing/SPARK-18617-follow-up.
uzadude pushed a commit to uzadude/spark that referenced this pull request Jan 27, 2017
…te. Receiver data should be deserialized properly

## What changes were proposed in this pull request?

Avoid to create multiple threads to stop StreamingContext. Otherwise, the latch added in apache#16091 can be passed too early.

## How was this patch tested?

Jenkins

Author: Shixiong Zhu <[email protected]>

Closes apache#16105 from zsxwing/SPARK-18617-2.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants