[SPARK-25832][SQL][BRANCH-2.4] Revert newly added map related functions #22827
Conversation
…g arrays_overlap, array_repeat, map_entries to SparkR
|
@felixcheung @mengxr The last commit f1f3d0b is for R related revert. Please take a look |
| @@ -65,21 +65,3 @@ create or replace temporary view nested as values | |||
| (1, map(1, 1, 2, 2, 3, 3)), | |||
| (2, map(4, 4, 5, 5, 6, 6)) | |||
| as t(x, ys); | |||
There was a problem hiding this comment.
We should revert line 64~67 because they are introduced by SPARK-23939 Add transform_keys function.
|
Also, please remove |
|
@dongjoon-hyun I think that can be kept. |
| create or replace temporary view nested as values | ||
| (1, map(1, 1, 2, 2, 3, 3)), | ||
| (2, map(4, 4, 5, 5, 6, 6)) | ||
| as t(x, ys); |
There was a problem hiding this comment.
higher-order-functions.sql.out together?
There was a problem hiding this comment.
That has been removed already
|
@gatorsmile . Could you put |
|
Test build #98029 has finished for PR 22827 at commit
|
gatorsmile
changed the title
|
Test build #98034 has finished for PR 22827 at commit
|
|
thanks, merging to 2.4! |
## What changes were proposed in this pull request? - Revert [SPARK-23935][SQL] Adding map_entries function: #21236 - Revert [SPARK-23937][SQL] Add map_filter SQL function: #21986 - Revert [SPARK-23940][SQL] Add transform_values SQL function: #22045 - Revert [SPARK-23939][SQL] Add transform_keys function: #22013 - Revert [SPARK-23938][SQL] Add map_zip_with function: #22017 - Revert the changes of map_entries in [SPARK-24331][SPARKR][SQL] Adding arrays_overlap, array_repeat, map_entries to SparkR: #21434 ## How was this patch tested? The existing tests. Closes #22827 from gatorsmile/revertMap2.4. Authored-by: gatorsmile <[email protected]> Signed-off-by: Wenchen Fan <[email protected]>
|
LGTM too |
|
@gatorsmile Hey, why were these functions reverted? |
What changes were proposed in this pull request?
How was this patch tested?
The existing tests.