[SPARK-25832][SQL] Remove newly added map related functions #22828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongjoon-hyun
commented
Oct 25, 2018
| @@ -313,7 +313,6 @@ exportMethods("%<=>%", | |||
| "lower", | |||
| "lpad", | |||
| "ltrim", | |||
| "map_entries", | |||
There was a problem hiding this comment.
Could you review this, @felixcheung ?
dongjoon-hyun
commented
Oct 25, 2018
| sc = SparkContext._active_spark_context | ||
| return Column(sc._jvm.functions.map_entries(_to_java_column(col))) | ||
|
|
||
|
|
There was a problem hiding this comment.
Could you review this, @HyukjinKwon and @BryanCutler ?
dongjoon-hyun
commented
Oct 25, 2018
| expression[ArrayFilter]("filter"), | ||
| expression[ArrayExists]("exists"), | ||
| expression[ArrayAggregate]("aggregate"), | ||
| expression[TransformValues]("transform_values"), | ||
| expression[TransformKeys]("transform_keys"), | ||
| expression[MapZipWith]("map_zip_with"), |
There was a problem hiding this comment.
Could you review this, @gatorsmile and @cloud-fan ?
dongjoon-hyun
commented
Oct 25, 2018
| @@ -61,8 +61,6 @@ | |||
| */ | |||
| public final class UnsafeRow extends InternalRow implements Externalizable, KryoSerializable { | |||
|
|
|||
| public static final int WORD_SIZE = 8; | |||
|
|
|||
There was a problem hiding this comment.
This is added by map_entries
|
To run the Jenkins faster, I create a standalone PR instead of making a PR to #22821 . |
dongjoon-hyun
changed the title
|
Oh, I'm closing this in favor of #22827. |
|
Test build #98030 has finished for PR 22828 at commit
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to supercede #22821 . The main author is @cloud-fan .
According to the discussion in RC4 voting thread and SPARK-25829, Spark current has a very weird behavior when we have duplicated keys in map. The newly added map-related functions in Apache Spark 2.4.0 make it worse. For instance,
map_filtermay return incorrect result like SPARK-25823Before we entire fix the map behavior, we should not expose these functions to users.
How was this patch tested?
Pass the Jenkins.