Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-29269][PYTHON][ML] Pyspark ALSModel support getters/setters #25947

Closed
wants to merge 4 commits into from
Closed

[SPARK-29269][PYTHON][ML] Pyspark ALSModel support getters/setters #25947

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e2850cc
[SPARK-29269][PYTHON][ML] Pyspark ALSModel support getters/setters
huaxingao Sep 27, 2019
875f9fb
address comments
huaxingao Sep 28, 2019
be2037e
change :py:attr to :py:class for classes
huaxingao Oct 3, 2019
1d1f041
add extra line before .. versionadded
huaxingao Oct 3, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion mllib/src/main/scala/org/apache/spark/ml/recommendation/ALS.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ private[recommendation] trait ALSModelParams extends Params with HasPredictionCo
* Common params for ALS.
*/
private[recommendation] trait ALSParams extends ALSModelParams with HasMaxIter with HasRegParam
with HasPredictionCol with HasCheckpointInterval with HasSeed {
with HasCheckpointInterval with HasSeed {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because ALSModelParams already has HasPredictionCol?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. It seems to be redundant to me.


/**
* Param for rank of the matrix factorization (positive).
Expand Down
Loading