Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-50507][PYTHON][TESTS] Group pandas function related tests #49074

Closed

Conversation

zhengruifeng
Copy link
Contributor

What changes were proposed in this pull request?

Group pandas function related tests

Why are the changes needed?

these tests were grouped in classic side, also group the parity tests for consistency

Does this PR introduce any user-facing change?

no, test-only

How was this patch tested?

updated ci

Was this patch authored or co-authored using generative AI tooling?

no

Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need a JIRA issue for this, @zhengruifeng . :)

+1 for the code.

@zhengruifeng zhengruifeng changed the title [MINOR][PYTHON][TESTS] Group pandas function related tests [SPARK-50507][PYTHON][TESTS] Group pandas function related tests Dec 6, 2024
@zhengruifeng
Copy link
Contributor Author

@dongjoon-hyun thanks, add the JIRA number

Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM. Thank you, @zhengruifeng and @HyukjinKwon .
Merged to master for Apache Spark 4.0.0 on February 2025.

@zhengruifeng zhengruifeng deleted the group_connect_test_pandas branch December 6, 2024 01:51
HyukjinKwon added a commit that referenced this pull request Dec 9, 2024
…ure Python test

### What changes were proposed in this pull request?

This PR is a followup of #49074 that adds refactored package into pure Python test

### Why are the changes needed?

In order to fix the pure Python build https://github.com/apache/spark/actions/runs/12215379954/job/34077255570.

### Does this PR introduce _any_ user-facing change?

No, test-only.

### How was this patch tested?

Will monitor the build.

### Was this patch authored or co-authored using generative AI tooling?

No.

Closes #49106 from HyukjinKwon/SPARK-50507-followup.

Authored-by: Hyukjin Kwon <[email protected]>
Signed-off-by: Hyukjin Kwon <[email protected]>
a0x8o added a commit to a0x8o/spark that referenced this pull request Dec 9, 2024
…ure Python test

### What changes were proposed in this pull request?

This PR is a followup of apache/spark#49074 that adds refactored package into pure Python test

### Why are the changes needed?

In order to fix the pure Python build https://github.com/apache/spark/actions/runs/12215379954/job/34077255570.

### Does this PR introduce _any_ user-facing change?

No, test-only.

### How was this patch tested?

Will monitor the build.

### Was this patch authored or co-authored using generative AI tooling?

No.

Closes #49106 from HyukjinKwon/SPARK-50507-followup.

Authored-by: Hyukjin Kwon <[email protected]>
Signed-off-by: Hyukjin Kwon <[email protected]>
HyukjinKwon added a commit that referenced this pull request Dec 10, 2024
…ure Python test

### What changes were proposed in this pull request?

This PR is a followup of #49074 that adds refactored package into pure Python test

### Why are the changes needed?

In order to fix the pure Python build https://github.com/apache/spark/actions/runs/12215379954/job/34077255570.

### Does this PR introduce _any_ user-facing change?

No, test-only.

### How was this patch tested?

Will monitor the build.

### Was this patch authored or co-authored using generative AI tooling?

No.

Closes #49119 from HyukjinKwon/SPARK-50507-followup2.

Authored-by: Hyukjin Kwon <[email protected]>
Signed-off-by: Hyukjin Kwon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants