Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(3059): Extend capabilities of time selection bar #3066

Conversation

dominikriemer
Copy link
Member

Purpose

Improve the time selection bar in the data explorer by adding more quick selections and replacing the bar with a menu.

Remarks

PR introduces (a) breaking change(s): <yes/no>

PR introduces (a) deprecation(s): <yes/no>

@github-actions github-actions bot added ui Anything that affects the UI testing Relates to any kind of test (unit test, integration, or E2E test). labels Jul 25, 2024
@dominikriemer dominikriemer marked this pull request as ready for review July 25, 2024 21:53
@@ -19,7 +19,8 @@
export interface TimeSettings {
startTime: number;
endTime: number;
dynamicSelection: 15 | 60 | 1440 | 10080 | 43800 | 525600 | -1;
// deprecated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be removed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to keep it for now for backwards compatibility but can remove it later.

@dominikriemer dominikriemer merged commit f560d1e into 3032-harmonize-data-explorer-and-live-dashboard Jul 26, 2024
21 checks passed
@dominikriemer dominikriemer deleted the 3059-extend-capabilities-of-time-selection-bar branch July 26, 2024 09:11
dominikriemer added a commit that referenced this pull request Aug 19, 2024
* feat(#3033): Support modification of data views (#3034)

* feat(#3033): Support modification of data views

* Fix checkstyle

* Fix cypress

* Remove cypress selector

* feat(#3043): Add data view selection to data explorer dashboard (#3044)

* feat(#3043): Add data view selection to data explorer dashboard

* Add routing service

* Fix cypress tests and modify routing

* feat(3059): Extend capabilities of time selection bar (#3066)

* feat(#3059): Replace time selection bar with menu

* Fix tests

* Support global and widget time

* Fix time update

* feat(#3068): Add refresh interval to data explorer dashboard (#3069)

* feat(#3068): Add refresh interval to data explorer dashboard

* Remove empty stylesheet

* feat(#3079): Add permission management to data views (#3082)

* feat(#3079): Add migration for existing data views

* Fix checkstyle

* Add permissions to rest interface

* feat(#3091): Add option to configure time ordering (#3092)

* feat(#3091): Add option to configure time ordering

* Remove deprecated model

* Fix checkstyle

* test: Add time order test + minor changes (#3113)

* added time order test + minor changes

* minor changes for e2e test

---------

Co-authored-by: Marcelfrueh <[email protected]>

* feat(#3090): Add gauge chart to data explorer (#3127)

* feat(#3090): Add gauge chart to data explorer

* Cleanup

* Fix tests

* Add dialog window for deleting data views/dashboards and test functionality with new E2E-test (#3137)

* Add dialog window for deletion of data view and dashboards + add tests for this feature

* Enhance test with cancellation of deletion

* bug fixes and minor changes in data explorer

* new functions for data lake utils + fixes for delete-widget-test

* Update ts model

---------

Co-authored-by: Marcelfrueh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Relates to any kind of test (unit test, integration, or E2E test). ui Anything that affects the UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants