-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(3059): Extend capabilities of time selection bar #3066
Merged
dominikriemer
merged 4 commits into
3032-harmonize-data-explorer-and-live-dashboard
from
3059-extend-capabilities-of-time-selection-bar
Jul 26, 2024
Merged
feat(3059): Extend capabilities of time selection bar #3066
dominikriemer
merged 4 commits into
3032-harmonize-data-explorer-and-live-dashboard
from
3059-extend-capabilities-of-time-selection-bar
Jul 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
ui
Anything that affects the UI
testing
Relates to any kind of test (unit test, integration, or E2E test).
labels
Jul 25, 2024
tenthe
approved these changes
Jul 26, 2024
@@ -19,7 +19,8 @@ | |||
export interface TimeSettings { | |||
startTime: number; | |||
endTime: number; | |||
dynamicSelection: 15 | 60 | 1440 | 10080 | 43800 | 525600 | -1; | |||
// deprecated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this be removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to keep it for now for backwards compatibility but can remove it later.
dominikriemer
merged commit Jul 26, 2024
f560d1e
into
3032-harmonize-data-explorer-and-live-dashboard
21 checks passed
dominikriemer
added a commit
that referenced
this pull request
Aug 19, 2024
* feat(#3033): Support modification of data views (#3034) * feat(#3033): Support modification of data views * Fix checkstyle * Fix cypress * Remove cypress selector * feat(#3043): Add data view selection to data explorer dashboard (#3044) * feat(#3043): Add data view selection to data explorer dashboard * Add routing service * Fix cypress tests and modify routing * feat(3059): Extend capabilities of time selection bar (#3066) * feat(#3059): Replace time selection bar with menu * Fix tests * Support global and widget time * Fix time update * feat(#3068): Add refresh interval to data explorer dashboard (#3069) * feat(#3068): Add refresh interval to data explorer dashboard * Remove empty stylesheet * feat(#3079): Add permission management to data views (#3082) * feat(#3079): Add migration for existing data views * Fix checkstyle * Add permissions to rest interface * feat(#3091): Add option to configure time ordering (#3092) * feat(#3091): Add option to configure time ordering * Remove deprecated model * Fix checkstyle * test: Add time order test + minor changes (#3113) * added time order test + minor changes * minor changes for e2e test --------- Co-authored-by: Marcelfrueh <[email protected]> * feat(#3090): Add gauge chart to data explorer (#3127) * feat(#3090): Add gauge chart to data explorer * Cleanup * Fix tests * Add dialog window for deleting data views/dashboards and test functionality with new E2E-test (#3137) * Add dialog window for deletion of data view and dashboards + add tests for this feature * Enhance test with cancellation of deletion * bug fixes and minor changes in data explorer * new functions for data lake utils + fixes for delete-widget-test * Update ts model --------- Co-authored-by: Marcelfrueh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Improve the time selection bar in the data explorer by adding more quick selections and replacing the bar with a menu.
Remarks
PR introduces (a) breaking change(s): <yes/no>
PR introduces (a) deprecation(s): <yes/no>