Add dialog window for deleting data views/dashboards and test functionality with new E2E-test #3137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
ui
tenthe
requested changes
Aug 14, 2024
There was a problem hiding this comment.
Hi @Marcelfrueh,
Thanks for the test. That looks good.
Would you mind creating utils functions in the DataLakeUtils for the different actions?
I'm not quite sure yet what the best API is for our testing framework, but I would suggest that if we have actions that are used multiple times, we put them in the utils. What do you think?
Marcelfrueh
force-pushed
the
data-explorer-dialog
branch
from
0089841 to
0cdecb8
Compare
tenthe
approved these changes
Aug 19, 2024
dominikriemer
merged commit 77c4966
into
apache:3032-harmonize-data-explorer-and-live-dashboard
21 checks passed
dominikriemer
added a commit
that referenced
this pull request
Aug 19, 2024
* feat(#3033): Support modification of data views (#3034) * feat(#3033): Support modification of data views * Fix checkstyle * Fix cypress * Remove cypress selector * feat(#3043): Add data view selection to data explorer dashboard (#3044) * feat(#3043): Add data view selection to data explorer dashboard * Add routing service * Fix cypress tests and modify routing * feat(3059): Extend capabilities of time selection bar (#3066) * feat(#3059): Replace time selection bar with menu * Fix tests * Support global and widget time * Fix time update * feat(#3068): Add refresh interval to data explorer dashboard (#3069) * feat(#3068): Add refresh interval to data explorer dashboard * Remove empty stylesheet * feat(#3079): Add permission management to data views (#3082) * feat(#3079): Add migration for existing data views * Fix checkstyle * Add permissions to rest interface * feat(#3091): Add option to configure time ordering (#3092) * feat(#3091): Add option to configure time ordering * Remove deprecated model * Fix checkstyle * test: Add time order test + minor changes (#3113) * added time order test + minor changes * minor changes for e2e test --------- Co-authored-by: Marcelfrueh <[email protected]> * feat(#3090): Add gauge chart to data explorer (#3127) * feat(#3090): Add gauge chart to data explorer * Cleanup * Fix tests * Add dialog window for deleting data views/dashboards and test functionality with new E2E-test (#3137) * Add dialog window for deletion of data view and dashboards + add tests for this feature * Enhance test with cancellation of deletion * bug fixes and minor changes in data explorer * new functions for data lake utils + fixes for delete-widget-test * Update ts model --------- Co-authored-by: Marcelfrueh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Add a dialog window when the delete button for a data view or dashboard is clicked. The dialog window demands confirmation from the user for deleting a data view or dashboard. To test the functionality of this dialog window, a new test is introduced: it checks that canceling a deletion action keeps the items intact and confirms successful deletion afterward. Moreover, deleteWidget.ts has been modified accordingly to consider the new dialog window.Minor bug fixes in editing mode for dashboard: "Discard"-button now functional for dashboard and data view, deletion of widget fixed, change of view mode in dashboard now also changeable in dashboard edition mode. Moreover, the delete-widget-test is fixed.
Remarks
PR introduces (a) breaking change(s): no
PR introduces (a) deprecation(s): no