Skip to content

Commit

Permalink
docs(release): add vote thread to result template (#12591)
Browse files Browse the repository at this point in the history
  • Loading branch information
villebro authored Jan 19, 2021
1 parent 7e99d76 commit 84266bf
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 1 deletion.
2 changes: 2 additions & 0 deletions RELEASING/email_templates/result_pmc.j2
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,8 @@ Negative votes:
{% endfor -%}
{%- endif %}

Link to vote thread: {{ vote_thread }}

We will work to complete the release process.

Thanks,
Expand Down
15 changes: 14 additions & 1 deletion RELEASING/send_email.py
Original file line number Diff line number Diff line change
Expand Up @@ -193,9 +193,21 @@ def vote_pmc(base_parameters, receiver_email):
type=str,
prompt="A List of people with -1 vote (ex: John)",
)
@click.option(
"--vote_thread",
default="",
type=str,
prompt="Permalink to the vote thread "
"(see https://lists.apache.org/[email protected])",
)
@click.pass_obj
def result_pmc(
base_parameters, receiver_email, vote_bindings, vote_nonbindings, vote_negatives
base_parameters,
receiver_email,
vote_bindings,
vote_nonbindings,
vote_negatives,
vote_thread,
):
template_file = "email_templates/result_pmc.j2"
base_parameters.template_arguments["receiver_email"] = receiver_email
Expand All @@ -208,6 +220,7 @@ def result_pmc(
base_parameters.template_arguments["vote_negatives"] = string_comma_to_list(
vote_negatives
)
base_parameters.template_arguments["vote_thread"] = vote_thread
message = render_template(template_file, **base_parameters.template_arguments)
inter_send_email(
base_parameters.username,
Expand Down

0 comments on commit 84266bf

Please sign in to comment.