Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(release): add vote thread to result template #12591

Merged
merged 1 commit into from
Jan 19, 2021

Conversation

villebro
Copy link
Member

SUMMARY

Add placeholder for email vote thread to to result email template.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@villebro villebro force-pushed the villebro/releasing-vote-thread branch from b1b9f68 to cc03cdc Compare January 19, 2021 10:07
@codecov-io
Copy link

codecov-io commented Jan 19, 2021

Codecov Report

Merging #12591 (cc03cdc) into master (e7a5d0d) will decrease coverage by 2.79%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12591      +/-   ##
==========================================
- Coverage   66.75%   63.96%   -2.80%     
==========================================
  Files        1015      486     -529     
  Lines       49638    29970   -19668     
  Branches     4839        0    -4839     
==========================================
- Hits        33137    19171   -13966     
+ Misses      16378    10799    -5579     
+ Partials      123        0     -123     
Flag Coverage Δ
cypress ?
javascript ?
python 63.96% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...essageToasts/utils/getToastsFromPyFlashMessages.js
...rc/views/CRUD/alert/components/AlertStatusIcon.tsx
...ontend/src/dashboard/util/serializeFilterScopes.js
...tend/src/explore/components/DisplayQueryButton.jsx
...ws/CRUD/data/savedquery/SavedQueryPreviewModal.tsx
...erset-frontend/src/datasource/DatasourceEditor.jsx
...frontend/src/explore/components/DataTablesPane.tsx
...shboard/util/charts/getFormDataWithExtraFilters.ts
superset-frontend/src/components/IconTooltip.tsx
...uperset-frontend/src/components/ExpandableList.tsx
... and 519 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7a5d0d...cc03cdc. Read the comment docs.

@villebro villebro changed the title release: add vote thread to result template docs(release): add vote thread to result template Jan 19, 2021
@villebro villebro merged commit 84266bf into apache:master Jan 19, 2021
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/S 🚢 1.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants