Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQL Lab doesn't display query history #11096

Closed
2 of 3 tasks
zuzana-vej opened this issue Sep 29, 2020 · 7 comments · Fixed by #11125
Closed
2 of 3 tasks

SQL Lab doesn't display query history #11096

zuzana-vej opened this issue Sep 29, 2020 · 7 comments · Fixed by #11125
Assignees
Labels
!deprecated-label:bug Deprecated label - Use #bug instead

Comments

@zuzana-vej
Copy link
Contributor

SQL Lab query history is broken. This bug is as a regression which was introduced some time between 1-2 weeks before 9/23.

Expected results

After user runs a query in SQL Lab, it should show in the Query History tab.

Actual results

The Query history is blank.

Screenshots

Screen Shot 2020-09-28 at 7 35 14 PM

How to reproduce the bug

  1. Go to SQL lab
  2. Run a simple query
  3. Click on Query history
  4. See there are no records

Environment

  • superset version: latest master

Checklist

Make sure these boxes are checked before submitting your issue - thank you!

  • I have checked the superset logs for python stacktraces and included it here as text if there are any.
  • I have reproduced the issue with at least the latest released version of superset.
  • I have checked the issue tracker for the same issue and I haven't found one similar.
@zuzana-vej zuzana-vej added the !deprecated-label:bug Deprecated label - Use #bug instead label Sep 29, 2020
@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the label #bug to this issue, with a confidence of 0.99. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

@junlincc
Copy link
Member

@dpgaspar, Daniel, could you please take a quick look, thanks! 🙏

@nytai
Copy link
Member

nytai commented Oct 1, 2020

Looks like this was introduced in #10981

@graceguo-supercat
Copy link

For async queries, we should be able to see old queries' results by clicking VIEW RESULTS link. this feature is not working right now:
EXx44bCHu0

@nytai
Copy link
Member

nytai commented Oct 1, 2020

@graceguo-supercat that looks like a separate issue, would you mind filing another ticket?

@mistercrunch
Copy link
Member

mistercrunch commented Oct 2, 2020

react-bootstrap's Popover + emotions break! We need to migrate all Popovers to antd quickly. I fixed the SpatialControl yesterday and I bet this is the same root cause...

@graceguo-supercat
Copy link

@nytai After the revert (or maybe have other fixes at the same time?), VIEW RESULTS link in query history works good now:
rJgWdqoKBT

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
!deprecated-label:bug Deprecated label - Use #bug instead
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants