refactor: Refactor QueryTable to use react-table #11216
Merged
+90
−112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zuzana-vej This PR is related to the issue #11096. Could you please verify that it works as you expect? |
Codecov Report
@@ Coverage Diff @@
## master #11216 +/- ##
==========================================
- Coverage 65.62% 61.37% -4.25%
==========================================
Files 834 834
Lines 39559 39559
Branches 3610 3604 -6
==========================================
- Hits 25959 24278 -1681
- Misses 13492 15100 +1608
- Partials 108 181 +73
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
kgabryje
changed the title
kgabryje
force-pushed
the
react-table/querytable
branch
5 times, most recently
from
e03cfb0 to
aeabbb2
Compare
kgabryje
force-pushed
the
react-table/querytable
branch
from
aeabbb2 to
1064e44
Compare
kgabryje
changed the title
rusackas
reviewed
Oct 15, 2020
rusackas
reviewed
Oct 15, 2020
rusackas
reviewed
Oct 15, 2020
rusackas
reviewed
Oct 15, 2020
rusackas
reviewed
Oct 15, 2020
Co-authored-by: Evan Rusackas <[email protected]>
Co-authored-by: Evan Rusackas <[email protected]>
mistercrunch
approved these changes
Oct 19, 2020
auxten
pushed a commit
to auxten/incubator-superset
that referenced
this pull request
Nov 20, 2020
* Refactor QueryTable to use react-table * Fix lodash import * Fix tests * Fix imports and QuerySearch styles * Update superset-frontend/src/SqlLab/components/QuerySearch.jsx Co-authored-by: Evan Rusackas <[email protected]> * Update superset-frontend/src/SqlLab/components/QuerySearch.jsx Co-authored-by: Evan Rusackas <[email protected]> * Lint fix * Refactored QueryTable into functional component * Remove calculating content height * Lint fix Co-authored-by: Evan Rusackas <[email protected]>
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Re-reverts #10981, which was reverted due to the issue #11096. Uses custom TableView component based on react-table library.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TEST PLAN
ADDITIONAL INFORMATION