Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Revert "Replace reactable with DataTable from superset-ui in QueryTab… #11125

Merged
merged 1 commit into from
Oct 1, 2020

Conversation

nytai
Copy link
Member

@nytai nytai commented Oct 1, 2020

…le (#10981)"

This reverts commit e93d92e.

SUMMARY

See linked issue

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

-CI, manual verification

ADDITIONAL INFORMATION

@nytai
Copy link
Member Author

nytai commented Oct 1, 2020

@kgabryje I opened this as a quickfix. If you can fix forward that would probably be better.

Copy link

@graceguo-supercat graceguo-supercat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. thanks for quick fix!

@nytai nytai merged commit 7a72082 into apache:master Oct 1, 2020
@nytai nytai deleted the tai/fix-sqllab-history branch October 1, 2020 17:06
auxten pushed a commit to auxten/incubator-superset that referenced this pull request Nov 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SQL Lab doesn't display query history
2 participants