-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add more required checks for branch protection #12969
Conversation
Codecov Report
@@ Coverage Diff @@
## master #12969 +/- ##
===========================================
- Coverage 69.18% 52.97% -16.22%
===========================================
Files 1025 480 -545
Lines 48814 17315 -31499
Branches 5188 4485 -703
===========================================
- Hits 33772 9172 -24600
+ Misses 14908 8143 -6765
+ Partials 134 0 -134
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
9f9253c
to
6d30cdb
Compare
6d30cdb
to
46dd441
Compare
@ktmud thanks for all the help on these.. it's looking good so far. |
.asf.yaml
Outdated
@@ -61,8 +61,12 @@ github: | |||
# contexts are the names of checks that must pass | |||
contexts: | |||
- check | |||
- docker-release |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wait a minute.... docker-release
should not be in the required list. It's only triggered on replease:published
event:
https://github.com/apache/superset/blob/master/.github/workflows/docker-release.yml#L4-L5
You probably want the Docker / build job instead.
(Would be nice to rename this to docker-build
, too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, there were three build
actions. I thought there were only two, but I see it was because the third was on publish. Ok, I renamed this one in a separate PR just to be safe. We can merge that one first: #12980
@eschutho could you add this change to your branch: https://github.com/preset-io/superset/pull/85/files ? |
🏷 ready-to-merge |
I removed docker-release in this PR and I'll add the docker build into https://github.com/apache/superset/pull/12970/files |
SUMMARY
Continuation of #12921 and #12928, this PR adds more required github checks.
TEST PLAN
verify that the correct tests are required after this is merged. If this yml file doesn't match correctly, we will need to rename the checks so that they match or open an infra ticket to Apache to update it.
ADDITIONAL INFORMATION