Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add more required checks for branch protection #12969

Merged
merged 2 commits into from
Feb 7, 2021

Conversation

eschutho
Copy link
Member

@eschutho eschutho commented Feb 5, 2021

SUMMARY

Continuation of #12921 and #12928, this PR adds more required github checks.

TEST PLAN

verify that the correct tests are required after this is merged. If this yml file doesn't match correctly, we will need to rename the checks so that they match or open an infra ticket to Apache to update it.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@eschutho eschutho marked this pull request as draft February 5, 2021 19:07
@eschutho eschutho changed the title add more checks chore: add more checks Feb 5, 2021
@ktmud ktmud changed the title chore: add more checks chore: add more required checks for branch protection Feb 5, 2021
@codecov-io
Copy link

codecov-io commented Feb 5, 2021

Codecov Report

Merging #12969 (9f9253c) into master (2eff860) will decrease coverage by 16.21%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #12969       +/-   ##
===========================================
- Coverage   69.18%   52.97%   -16.22%     
===========================================
  Files        1025      480      -545     
  Lines       48814    17315    -31499     
  Branches     5188     4485      -703     
===========================================
- Hits        33772     9172    -24600     
+ Misses      14908     8143     -6765     
+ Partials      134        0      -134     
Flag Coverage Δ
cypress 52.97% <ø> (+2.14%) ⬆️
javascript ?
python ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...uperset-frontend/src/dashboard/util/dnd-reorder.js 0.00% <0.00%> (-100.00%) ⬇️
...rset-frontend/src/dashboard/util/getEmptyLayout.js 0.00% <0.00%> (-100.00%) ⬇️
...dashboard/components/resizable/ResizableHandle.jsx 0.00% <0.00%> (-100.00%) ⬇️
...dashboard/components/nativeFilters/ScopingTree.tsx 6.25% <0.00%> (-93.75%) ⬇️
.../src/dashboard/util/getFilterScopeFromNodesTree.js 0.00% <0.00%> (-93.48%) ⬇️
...set-frontend/src/views/CRUD/alert/ExecutionLog.tsx 11.76% <0.00%> (-88.24%) ⬇️
...src/dashboard/components/gridComponents/Header.jsx 10.52% <0.00%> (-86.85%) ⬇️
superset-frontend/src/components/IconTooltip.tsx 13.33% <0.00%> (-86.67%) ⬇️
...rc/dashboard/components/gridComponents/Divider.jsx 13.33% <0.00%> (-86.67%) ⬇️
...perset-frontend/src/views/CRUD/welcome/Welcome.tsx 2.94% <0.00%> (-85.95%) ⬇️
... and 887 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2eff860...9f9253c. Read the comment docs.

@eschutho eschutho force-pushed the elizabeth/add-more-more-checks branch from 9f9253c to 6d30cdb Compare February 5, 2021 20:54
@eschutho eschutho marked this pull request as ready for review February 5, 2021 20:54
@eschutho eschutho force-pushed the elizabeth/add-more-more-checks branch from 6d30cdb to 46dd441 Compare February 5, 2021 20:55
@eschutho
Copy link
Member Author

eschutho commented Feb 5, 2021

@ktmud thanks for all the help on these.. it's looking good so far.

.asf.yaml Outdated
@@ -61,8 +61,12 @@ github:
# contexts are the names of checks that must pass
contexts:
- check
- docker-release
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait a minute.... docker-release should not be in the required list. It's only triggered on replease:published event:

https://github.com/apache/superset/blob/master/.github/workflows/docker-release.yml#L4-L5

You probably want the Docker / build job instead.

docker-build

(Would be nice to rename this to docker-build, too.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, there were three build actions. I thought there were only two, but I see it was because the third was on publish. Ok, I renamed this one in a separate PR just to be safe. We can merge that one first: #12980

@ktmud
Copy link
Member

ktmud commented Feb 5, 2021

@eschutho could you add this change to your branch: https://github.com/preset-io/superset/pull/85/files ?

@eschutho
Copy link
Member Author

eschutho commented Feb 6, 2021

🏷 ready-to-merge

@superset-github-bot superset-github-bot bot added the need:merge The PR is ready to be merged label Feb 6, 2021
@eschutho
Copy link
Member Author

eschutho commented Feb 6, 2021

@eschutho could you add this change to your branch: https://github.com/preset-io/superset/pull/85/files ?

I removed docker-release in this PR and I'll add the docker build into https://github.com/apache/superset/pull/12970/files

@ktmud ktmud merged commit 6886134 into apache:master Feb 7, 2021
@eschutho eschutho deleted the elizabeth/add-more-more-checks branch February 25, 2021 03:11
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels need:merge The PR is ready to be merged preset-io size/XS 🚢 1.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants