Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: use git submodules for Chart Actions #14211

Merged
merged 9 commits into from
Apr 17, 2021
Merged

ci: use git submodules for Chart Actions #14211

merged 9 commits into from
Apr 17, 2021

Conversation

jawabuu
Copy link
Contributor

@jawabuu jawabuu commented Apr 17, 2021

SUMMARY

This adds chart actions submodules to allow chart actions to run.
Added because of implementation for using git submodules for (securely) using third party Github Actions (#12709)
Related to #14163 that has been accepted.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

  • [ X] Has associated issue: feat: publish superset helm chart #14163
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API
    @craig-rueda

@jawabuu
Copy link
Contributor Author

jawabuu commented Apr 17, 2021

@amitmiran137 @craig-rueda
See chart linter in action
https://github.com/apache/superset/pull/14211/checks?check_run_id=2368816356
For some reason chart maintainer fails validation, should I change it?

@pull-request-size pull-request-size bot added size/M and removed size/S labels Apr 17, 2021
@jawabuu
Copy link
Contributor Author

jawabuu commented Apr 17, 2021

Lint works great now. Should be OK to merge
https://github.com/apache/superset/pull/14211/checks?check_run_id=2368915717

@amitmiran137
Copy link
Member

Again , the work your doing here is amazing!!

@craig-rueda
Copy link
Member

Apache just approved the action added in #14163 . Closing this in favor of previous PR.

@craig-rueda craig-rueda reopened this Apr 17, 2021
@craig-rueda
Copy link
Member

After testing, I think this is a better solution, as it doesn't require additional approvals from Apache infra :)

@amitmiran137 amitmiran137 merged commit 6132563 into apache:master Apr 17, 2021
@jawabuu jawabuu deleted the chart-actions-submodules branch April 18, 2021 19:25
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
@jawabuu
ci: use git submodules for Chart Actions (apache#14211)
d5578c6 
* Add chart-action submodules

* use local github actions for chart actions

* Run actions checkout for local checkout

* Run lint when PR is edited

* Remove path filter and dummy value

* Fix fetch-depth

* Test chart version bump

* Update maintainer to pass validation

* Update maintainer to pass validation
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 labels Mar 12, 2024
This was referenced Oct 5, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@craig-rueda craig-rueda craig-rueda approved these changes

Assignees

@ktmud ktmud

@craig-rueda craig-rueda

Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 1.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jawabuu @amitmiran137 @craig-rueda @ktmud @mistercrunch