Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use git submodules for Chart Actions #14211

Merged
merged 9 commits into from
Apr 17, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/actions/chart-releaser-action
Submodule chart-releaser-action added at 120944
1 change: 1 addition & 0 deletions .github/actions/chart-testing-action
Submodule chart-testing-action added at b0d445
9 changes: 5 additions & 4 deletions .github/workflows/superset-helm-lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,16 +2,17 @@ name: Lint and Test Charts

on:
pull_request:
paths:
- 'helm/**'
types: [opened, edited, reopened, synchronize]

jobs:
lint-test:
runs-on: ubuntu-latest
steps:
- name: Checkout
- name: "Checkout ${{ github.ref }} ( ${{ github.sha }} )"
uses: actions/checkout@v2
with:
persist-credentials: false
submodules: recursive
fetch-depth: 0

- name: Set up Helm
Expand All @@ -24,7 +25,7 @@ jobs:
python-version: 3.7

- name: Set up chart-testing
uses: helm/chart-testing-action@v2.0.1
uses: ./.github/actions/chart-testing-action

- name: Run chart-testing (list-changed)
id: list-changed
Expand Down
6 changes: 4 additions & 2 deletions .github/workflows/superset-helm-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,11 @@ jobs:
release:
runs-on: ubuntu-latest
steps:
- name: Checkout
- name: "Checkout ${{ github.ref }} ( ${{ github.sha }} )"
uses: actions/checkout@v2
with:
persist-credentials: false
submodules: recursive
fetch-depth: 0

- name: Configure Git
Expand All @@ -27,7 +29,7 @@ jobs:
version: v3.5.4

- name: Run chart-releaser
uses: helm/chart-releaser-action@v1.2.0
uses: ./.github/actions/chart-releaser-action
with:
charts_dir: helm
env:
Expand Down
6 changes: 6 additions & 0 deletions .gitmodules
Original file line number Diff line number Diff line change
Expand Up @@ -30,3 +30,9 @@
[submodule ".github/actions/comment-on-pr"]
path = .github/actions/comment-on-pr
url = https://github.com/unsplash/comment-on-pr
[submodule ".github/actions/chart-testing-action"]
path = .github/actions/chart-testing-action
url = https://github.com/helm/chart-testing-action
[submodule ".github/actions/chart-releaser-action"]
path = .github/actions/chart-releaser-action
url = https://github.com/helm/chart-releaser-action
8 changes: 4 additions & 4 deletions helm/superset/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,10 @@ appVersion: "1.0"
description: Apache Superset is a modern, enterprise-ready business intelligence web application
name: superset
maintainers:
- name: Chuan-Yen Chiang
email: cychiang0823@gmail.com
url: https://github.com/cychiang
version: 0.1.0
- name: craig-rueda
email: craig@craigrueda.com
url: https://github.com/craig-rueda
version: 0.1.1
dependencies:
- name: postgresql
version: 10.2.0
Expand Down
2 changes: 0 additions & 2 deletions helm/superset/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -372,5 +372,3 @@ nodeSelector: {}
tolerations: []

affinity: {}

dummy: true