Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add alerts & reports to docker compose #14267

Merged
merged 6 commits into from
Apr 22, 2021

Conversation

dpgaspar
Copy link
Member

@dpgaspar dpgaspar commented Apr 21, 2021

SUMMARY

Adds alerts and reports to docker-compose for developers. Notifications are set to dry run on docker compose.

TEST PLAN

Start docker-compose, add an alert and inspect beat and worker logs, check for the dry run notification message:
Would send notification for alert Alert1, to {"target": "[email protected]"}

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@pull-request-size pull-request-size bot added size/L and removed size/M labels Apr 22, 2021
@dpgaspar dpgaspar marked this pull request as ready for review April 22, 2021 10:16
@codecov
Copy link

codecov bot commented Apr 22, 2021

Codecov Report

Merging #14267 (e467723) into master (852e840) will decrease coverage by 0.20%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14267      +/-   ##
==========================================
- Coverage   76.97%   76.77%   -0.21%     
==========================================
  Files         953      953              
  Lines       48061    48065       +4     
  Branches     5971     5971              
==========================================
- Hits        36997    36902      -95     
- Misses      10862    10961      +99     
  Partials      202      202              
Flag Coverage Δ
hive ?
mysql 80.73% <100.00%> (+<0.01%) ⬆️
postgres 80.77% <100.00%> (?)
presto ?
python 80.85% <100.00%> (-0.39%) ⬇️
sqlite 80.37% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/config.py 91.06% <100.00%> (+0.03%) ⬆️
superset/reports/commands/execute.py 92.88% <100.00%> (+0.03%) ⬆️
superset/db_engines/hive.py 0.00% <0.00%> (-82.15%) ⬇️
superset/db_engine_specs/hive.py 74.42% <0.00%> (-16.42%) ⬇️
superset/db_engine_specs/presto.py 83.36% <0.00%> (-6.95%) ⬇️
superset/views/database/mixins.py 81.03% <0.00%> (-1.73%) ⬇️
superset/connectors/sqla/models.py 88.37% <0.00%> (-1.46%) ⬇️
superset/db_engine_specs/base.py 87.05% <0.00%> (-0.45%) ⬇️
superset/dashboards/dao.py 95.57% <0.00%> (-0.40%) ⬇️
superset/models/core.py 88.85% <0.00%> (-0.28%) ⬇️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 852e840...e467723. Read the comment docs.

@pull-request-size pull-request-size bot added size/M and removed size/L labels Apr 22, 2021
@dpgaspar dpgaspar merged commit 38a7c53 into apache:master Apr 22, 2021
@dpgaspar dpgaspar deleted the feat/alerts-reports-docker branch April 22, 2021 16:42
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
* feat: add alerts & reports to docker compose

* change to firefox

* add missing package
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/M 🚢 1.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants