Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docker-compose): use dev image for docker-compose-non-dev.yml #14342

Merged
merged 1 commit into from
Apr 27, 2021

Conversation

nytai
Copy link
Member

@nytai nytai commented Apr 26, 2021

SUMMARY

Since #14267 added support for alerts/reports (and thumbnails) to the docker file it makes sense to use the dev image in docker-compose-non-dev.yml so that users can take advantage of the alerts/reports functionality. This PR also bumps redis to latest as it's already being used in the default docker compose file.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A

TEST PLAN

docker-compose -f docker-compose-non-dev.yml pull && docker-compose -f docker-compose-non-dev.yml up brings up a working version of superset at localhost:8088

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@srinify
Copy link
Contributor

srinify commented Apr 27, 2021

This works great!

Screen Shot 2021-04-27 at 8 31 55 AM

Screen Shot 2021-04-27 at 8 31 48 AM

@srinify srinify merged commit 1ec743f into apache:master Apr 27, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/XS 🚢 1.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants