-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(dashboard): padding between rows within tabs #20366
Conversation
/testenv up |
@stephenLYZ Container image not yet published for this PR. Please try again when build is complete. |
@stephenLYZ Ephemeral environment creation failed. Please check the Actions logs for details. |
/testenv up |
@stephenLYZ Container image not yet published for this PR. Please try again when build is complete. |
@stephenLYZ Ephemeral environment creation failed. Please check the Actions logs for details. |
@stephenLYZ I don't really get the meaning of all these pipelines... can you point me to resources to better understand it, so that I can support in getting the PR merged? |
@gbusch It looks like a formatting issue, can you try running |
@stephenLYZ merged master and run format |
@gbusch Can you resolve the conflict so we are trying to get it? |
I think I messed this one up because I did not understand the pipelines at that time... |
SUMMARY
There should be padding between rows in a dashboard. Before, this did not work when the rows where within tabs. This is fixed here.
See this issue: #20303
BEFORE SCREENSHOT
AFTER SCREENSHOT
TESTING INSTRUCTIONS