Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dashboard): padding between rows within tabs #20366

Closed
wants to merge 4 commits into from

Conversation

gbusch
Copy link
Contributor

@gbusch gbusch commented Jun 13, 2022

SUMMARY

There should be padding between rows in a dashboard. Before, this did not work when the rows where within tabs. This is fixed here.
See this issue: #20303

BEFORE SCREENSHOT

Screenshot 2022-06-13 at 22 57 58

AFTER SCREENSHOT

Screenshot 2022-06-13 at 22 56 44

TESTING INSTRUCTIONS

  • Insert two charts into a new dashboard
  • Add a filter. When hovering over a filter, the selection box shows some space between the plots
  • When you move the charts into tabs, there is no space between plots any more (see first screenshot)
  • AFTER APPLYING CHANGES FROM PR:
  • Now there is also some space when the charts are within tabs (see second screenshot).

@stephenLYZ
Copy link
Member

/testenv up

@github-actions
Copy link
Contributor

@stephenLYZ Container image not yet published for this PR. Please try again when build is complete.

@github-actions
Copy link
Contributor

@stephenLYZ Ephemeral environment creation failed. Please check the Actions logs for details.

@stephenLYZ stephenLYZ self-requested a review June 16, 2022 16:42
@stephenLYZ
Copy link
Member

/testenv up

@github-actions
Copy link
Contributor

@stephenLYZ Container image not yet published for this PR. Please try again when build is complete.

@github-actions
Copy link
Contributor

@stephenLYZ Ephemeral environment creation failed. Please check the Actions logs for details.

@gbusch
Copy link
Contributor Author

gbusch commented Jul 4, 2022

@stephenLYZ I don't really get the meaning of all these pipelines... can you point me to resources to better understand it, so that I can support in getting the PR merged?

@stephenLYZ
Copy link
Member

stephenLYZ commented Jul 4, 2022

@gbusch It looks like a formatting issue, can you try running npm run format in the frontend?

@gbusch
Copy link
Contributor Author

gbusch commented Jul 4, 2022

@stephenLYZ merged master and run format

@stephenLYZ
Copy link
Member

@gbusch Can you resolve the conflict so we are trying to get it?

@gbusch
Copy link
Contributor Author

gbusch commented Sep 4, 2022

I think I messed this one up because I did not understand the pipelines at that time...
Probably it is easier to open a new - clean - PR: #21323 and close this one.

@gbusch gbusch closed this Sep 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants