fix(dashboard): padding between rows within tabs #21323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/testenv up |
|
@stephenLYZ Container image not yet published for this PR. Please try again when build is complete. |
|
@stephenLYZ Ephemeral environment creation failed. Please check the Actions logs for details. |
Codecov Report
@@ Coverage Diff @@
## master #21323 +/- ##
=======================================
Coverage 66.47% 66.47%
=======================================
Files 1789 1789
Lines 68382 68382
Branches 7276 7276
=======================================
Hits 45455 45455
Misses 21052 21052
Partials 1875 1875
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: It's the same PR as #20366. However, there were some issues with formatting and the pipelines (mainly because of lacking understanding on my side). So for this few-lines change, I guess it is easier I open a new PR and close the old one, rather than trying to fix the messed up old one...
SUMMARY
There should be padding between rows in a dashboard. Before, this did not work when the rows where within tabs. This is fixed here.
See this issue: #20303
BEFORE SCREENSHOT
AFTER SCREENSHOT
TESTING INSTRUCTIONS