-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cypress): make test chart time range deterministic #22567
Conversation
Codecov Report
@@ Coverage Diff @@
## master #22567 +/- ##
==========================================
- Coverage 66.91% 66.89% -0.03%
==========================================
Files 1851 1851
Lines 70709 70709
Branches 7766 7766
==========================================
- Hits 47316 47299 -17
- Misses 21371 21387 +16
- Partials 2022 2023 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
4804ae7
to
874fe73
Compare
SUMMARY
Cypress is currently failing due to a test chart having a "40 years ago" time range, causing the row count to drop by one every year (hence it's now 25 rows and not 26 rows):
Here we're changing the time range to be deterministic so we don't have to do this change annually. In addition,
since
anduntil
are moved intotime_range
from the birth names defaults, as they're overlapping withtime_range
.TESTING INSTRUCTIONS
ADDITIONAL INFORMATION