Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(AlertReports): preventing reset of notification settings when method does not change #27556

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,9 @@
}

const onMethodChange = (method: NotificationMethodOption) => {
fisjac marked this conversation as resolved.
Show resolved Hide resolved
if (method === setting.method) {
return;

Check warning on line 80 in superset-frontend/src/features/alerts/components/NotificationMethod.tsx

View check run for this annotation

Codecov / codecov/patch

superset-frontend/src/features/alerts/components/NotificationMethod.tsx#L80

Added line #L80 was not covered by tests
}
// Since we're swapping the method, reset the recipients
setRecipientValue('');
if (onUpdate) {
Expand Down
Loading