Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hexagon] Softmax slice op initial version #11559

Merged
merged 1 commit into from
Jun 24, 2022

Conversation

gayatripk1
Copy link
Contributor

@gayatripk1 gayatripk1 commented Jun 3, 2022

Thanks for contributing to TVM! Please refer to guideline https://tvm.apache.org/docs/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from Reviewers by @ them in the pull request thread.

This patch adds the initial python implementation softmax slice op for hexagon.

cc @mehrdadh

@github-actions github-actions bot requested a review from mehrdadh June 3, 2022 11:56
@mehrdadh
Copy link
Member

@gayatripk1 can you fix the merge conflict?

@mehrdadh
Copy link
Member

@gayatripk1 also please add some detail to the PR description.

@gayatripk1 gayatripk1 force-pushed the gayatripk1/softmax_slice_op branch from 2e29537 to 5b9bd4b Compare June 21, 2022 04:49
@mehrdadh
Copy link
Member

@gayatripk1 please rebase with main to resolve the conflict.

Resolve merge conflict in utils.py
@gayatripk1 gayatripk1 force-pushed the gayatripk1/softmax_slice_op branch from 5b9bd4b to 5b0933d Compare June 22, 2022 17:33
Copy link
Member

@mehrdadh mehrdadh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!


if __name__ == "__main__":

sys.exit(pytest.main(sys.argv))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can do this in a follow up:

  1. remove the new line
  2. replace sys.exit(pytest.main(sys.argv)) with tvm.testing.main()

@mehrdadh mehrdadh merged commit f1d30a2 into apache:main Jun 24, 2022
@@ -0,0 +1,140 @@
# Licensed to the Apache Software Foundation (ASF) under one
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Follow up PR: move this to under test_hexagon/topi

zxybazh pushed a commit to zxybazh/tvm that referenced this pull request Jun 26, 2022
blackkker pushed a commit to blackkker/tvm that referenced this pull request Jul 7, 2022
mikeseven pushed a commit to mikeseven/tvm that referenced this pull request Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants