[Adreno] Adapt reduction schedule for adreno #13100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment. Generated by tvm-bot |
Origin cuda schedule uses rfactor that is 10x-50x slower on Adreno than without barries
elvin-n
force-pushed
the
amalyshe/adreno_reduction
branch
from
4aa0dc6 to
5320706
Compare
echuraev
reviewed
Oct 17, 2022
echuraev
reviewed
Oct 18, 2022
areusch
added
the
needs-triage
areusch
removed
the
needs-triage
echuraev
approved these changes
Oct 19, 2022
|
@masahi could you please review/merge? |
masahi
approved these changes
Oct 24, 2022
xinetzone
pushed a commit
to daobook/tvm
that referenced
this pull request
Nov 10, 2022
* [Adreno] Adapt reduction schedule for adreno Origin cuda schedule uses rfactor that is 10x-50x slower on Adreno than without barries * Address PR comments * Remove copy-paste, start reuse cuda impl * Address pylint hits * Extend comment for cuda schedule_reduce_impl
xinetzone
pushed a commit
to daobook/tvm
that referenced
this pull request
Nov 25, 2022
* [Adreno] Adapt reduction schedule for adreno Origin cuda schedule uses rfactor that is 10x-50x slower on Adreno than without barries * Address PR comments * Remove copy-paste, start reuse cuda impl * Address pylint hits * Extend comment for cuda schedule_reduce_impl
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Origin cuda schedule uses rfactor that is 10x-50x slower on Adreno than without barries
for example mean on QHD picture on Snapdragon 888 with cuda schedule is executed for 69ms while with new proposed schedule is executed for 6.2
the same for argmin: 183ms -> 3.9ms