[WebGPU] Fix unexpected device lost error when intentional dispose #17250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tvm-bot rerun |
1 similar comment
|
@tvm-bot rerun |
tqchen
approved these changes
Aug 7, 2024
CharlieFRuan
added a commit
to mlc-ai/web-llm
that referenced
this pull request
Aug 8, 2024
No breaking changes. The only diff is the following PR: - #525 - This PR updates the engine reload() and unload() methods to allow users to abort an uncompleted reload() by either: - call unload() any time before reload() completed - call reload() again before the previous reload() completed - Besides, it fixes the previous issue where `device lost error` is raised unexpectedly when user simply switches a model ### TVMjs - To support the above PR, TVMjs is updated and compiled at apache/tvm@1fcb620 - Difference: - Device error lost fix: apache/tvm#17250 - Add AbortSignal to fetching APIs: - apache/tvm#17208 - apache/tvm#17227 - apache/tvm#17233
jzhao62
pushed a commit
to jzhao62/web-llm
that referenced
this pull request
Dec 8, 2024
No breaking changes. The only diff is the following PR: - mlc-ai#525 - This PR updates the engine reload() and unload() methods to allow users to abort an uncompleted reload() by either: - call unload() any time before reload() completed - call reload() again before the previous reload() completed - Besides, it fixes the previous issue where `device lost error` is raised unexpectedly when user simply switches a model ### TVMjs - To support the above PR, TVMjs is updated and compiled at apache/tvm@1fcb620 - Difference: - Device error lost fix: apache/tvm#17250 - Add AbortSignal to fetching APIs: - apache/tvm#17208 - apache/tvm#17227 - apache/tvm#17233
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue introduced in #17005.
deviceLostIsErrorwas introduced to make sure intentionaldispose()(hence webgpu'sdestroy()) does not cause device lost callback to treat it as an error. However, we cannot setdeviceLostIsErrorimmediately to true after callingthis.lib.dispose()(which callsdevice.destroy()) because WebGPU is asynchronous. Otherwise, we would trigger the device lost callback when callingInstance.dispose()to destroy device intentionally.