Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WebGPU] Fix unexpected device lost error when intentional dispose #17250

Merged
merged 1 commit into from
Aug 8, 2024
Merged

[WebGPU] Fix unexpected device lost error when intentional dispose #17250

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion web/src/runtime.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1122,7 +1122,7 @@ export class Instance implements Disposable {
// ctx release goes back into lib.
this.ctx.dispose();
this.lib.dispose();
this.deviceLostIsError = true;
// Cannot set deviceLostIsError back to true here because GPUDevice.destroy() is asynchronous.
}

/**
Expand Down Expand Up @@ -2122,6 +2122,7 @@ export class Instance implements Disposable {
this.dispose();
}
});
this.deviceLostIsError = true;

const webGPUContext = new WebGPUContext(
this.memory, device
Expand Down
Loading