Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete superfluous doclet and taglet JARs #134

Conversation

kriegaex
Copy link
Contributor

@jkesselm jkesselm merged commit 77f8040 into apache:xalan-java-mvn-refactored Nov 30, 2023
1 check failed
@jkesselm
Copy link
Contributor

Yep. You've retained top-level tools/xalan2jdoc.jar, which is good (since we haven't yet turned that back into source), but the others are artifacts of the original reorganization into modules and should have Gone Away.

@kriegaex
Copy link
Contributor Author

kriegaex commented Nov 30, 2023

Yep. You've retained top-level tools/xalan2jdoc.jar, which is good

That was not my intention. I have deleted it and also pushed the commit to the branch. For some reason, the PR was not updated on GitHub. Must be a glitch in their service, as usually that does not happen. Or you just merged a few minutes before I pushed.

I absolutely wanted to delete it, as we agreed on in our chat. There is no need to keep it in the current version, as it is still in the Git history. I already turned it into source, but deleted the decompiled sources again, because they cannot work on JDK 8, as explained in my corresponding commit.

I am going to create a follow-up PR for the missing commit.

@kriegaex kriegaex mentioned this pull request Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants