Delete xalan2jdoc.jar #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Running javadoc generation with or without it on the stylebook classpath had absolutely no effect. Comparing javadocs with and without it revealed that both directory trees were binary identical. Actually, on JDK 8 the JAR cannot have been working correctly anyway, because the JAR file contained Java 1.1 class files (major 45), which is OK. But it also uses several classes which are no longer available in JDK 8, i.e. the code cannot have been working there. For example, one class imported was com.sun.tools.doclets.IndexBuilder, which a web search found in JDKs 1.2 and 1.3. In 1.8, there is com.sun.tools.doclets.internal.toolkit.util.IndexBuilder, which might serve a similar purpose, but neither is public API nor the class referenced by the doclet code. I really think, this is just cruft that can go away.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #134, because that one was merged without this commit:
Running javadoc generation with or without it on the stylebook classpath had absolutely no effect. Comparing javadocs with and without it revealed that both directory trees were binary identical.
Actually, on JDK 8 the JAR cannot have been working correctly anyway, because the JAR file contained Java 1.1 class files (major 45), which is OK. But it also uses several classes which are no longer available in JDK 8, i.e. the code cannot have been working there. For example, one class imported was
com.sun.tools.doclets.IndexBuilder,which a web search found in JDKs 1.2 and 1.3. In 1.8, there is
com.sun.tools.doclets.internal.toolkit.util.IndexBuilder,which might serve a similar purpose, but neither is public API nor the class referenced by the doclet code. I really think, this is just cruft that can go away.
@jkesselm