Migrate to AirseekerRegistry contract #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Siegrift
force-pushed
the
upgrade-contracts3
branch
from
217d2a7 to
3b4620b
Compare
Siegrift
changed the title
Siegrift
force-pushed
the
upgrade-contracts3
branch
from
0c1ad3a to
5354a23
Compare
Siegrift
commented
Dec 21, 2023
There was a problem hiding this comment.
@peterjurco you can take a look at https://github.com/api3dao/airseeker-v2/blob/upgrade-contracts3/test/setup/contract.ts to see how contracts are setup and https://github.com/api3dao/airseeker-v2/blob/upgrade-contracts3/src/update-feeds-loops/contracts.ts how to work with it.
|
I made some changes to AirseekerRegistry that I haven't decided to keep yet. Giving a heads up because they probably cause the CI of this branch to fail. |
aquarat
approved these changes
Jan 2, 2024
* Update deterministic address * Expose data feed ID for local test configuration * Update contract function naming in local test configuration * Improve readability of comment * Check against unexpected update parameters format
Siegrift
force-pushed
the
upgrade-contracts3
branch
from
e542112 to
4e8f3d5
Compare
|
Thanks everyone 💪 . |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #163
Rationale
The contract is a bit more generic and allows supporting data feeds via ID (not dAPI name). The code was previously tailored to dAPIs and used often used
dapifor naming. These are renamed to a more generic and accuratedataFeedinstead.The contract name changed from
DapiDataRegistrytoAirseekerRegistry. It usesApi3ServerV1to read the data feed details and can return no data in case the data feed is not registered. This is now explicitly handled by skipping such data feeds and logging a warning.Both spec and diagrams are updated accordingly.