Multicall chain info #168
Merged
Multicall chain info #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Siegrift
force-pushed
the
upgrade-contracts3
branch
from
e542112 to
4e8f3d5
Compare
Siegrift
force-pushed
the
multicall-chain-info
branch
from
929fbd3 to
9fb525d
Compare
Siegrift
force-pushed
the
multicall-chain-info
branch
from
0cf68b8 to
2582117
Compare
Siegrift
force-pushed
the
multicall-chain-info
branch
from
2582117 to
24b1e40
Compare
aquarat
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #154
Rationale
See the issue description, comments and related Slack discussions for full context.
We fetch on-chain data in two places, 1) when fetching a batch of active data feeds and 2) when multi-calling beacon values for the batch. Both of these verify that chain ID matches the configuration and log a warning otherwise. During 1) we remember the block ID and use it to fetch the nonce (at that block) when making the update transaction. In 2) we fetch the values at
latestthe block number. See this discussion.When making an update transaction we log the sponsor wallet address and a nonce of the update transaction.
I've also updated the
local-test-configurationwhich was broken after #165.