fix: upgrade go-grpc package to fix panic bug #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ashish Tiwari <[email protected]>
Signed-off-by: revolyssup <[email protected]>
Signed-off-by: revolyssup <[email protected]>
Signed-off-by: revolyssup <[email protected]>
Signed-off-by: revolyssup <[email protected]>
| @@ -44,4 +44,5 @@ jobs: | |||
| - name: Script | |||
| run: | | |||
| export PATH=$OPENRESTY_PREFIX/nginx/sbin:$PATH | |||
| export GODEBUG=x509sha1=1 | |||
There was a problem hiding this comment.
After updating the package, the certs in the tests cannot be used as the tests fail with an error that its insecure to use sha1 algorithm[1]. This runtime flag skips the check[2]
There was a problem hiding this comment.
Either this, or we would need to regenerate certificates for tests using something like SHA256. Given these are just tests, I think using this flag is fine.
monkeyDluffy6017
approved these changes
Aug 2, 2023
Sn0rt
approved these changes
Aug 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #69