Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crypto/x509: respect GODEBUG changes during program lifetime [1.19 backport] #56438

Closed
gopherbot opened this issue Oct 26, 2022 · 2 comments
Closed

crypto/x509: respect GODEBUG changes during program lifetime [1.19 backport] #56438

gopherbot opened this issue Oct 26, 2022 · 2 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Milestone
Go1.19.4

Comments

@gopherbot
Copy link
Contributor

@rsc requested issue #56436 to be considered for backport to the next 1.19 minor release.

@gopherbot please backport
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Oct 26, 2022
@gopherbot gopherbot mentioned this issue Oct 26, 2022
Closed
@gopherbot gopherbot modified the milestones: Go1.19.3, Go1.19.4 Oct 26, 2022
@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/445655 mentions this issue: [release-branch.go1.19] crypto/x509: respect GODEBUG changes for allowing SHA1 certificates

@heschi heschi added the CherryPickApproved Used during the release process for point releases label Nov 2, 2022
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Nov 2, 2022
@gopherbot
Copy link
Contributor Author

Closed by merging 6109c07 to release-branch.go1.19.

gopherbot pushed a commit that referenced this issue Nov 8, 2022
@rsc
[release-branch.go1.19] crypto/x509: respect GODEBUG changes for allo…
6109c07 
…wing SHA1 certificates

This allows programs that want SHA1 support to call os.Setenv at startup
instead of insisting that users set the environment variable themselves.

For #41682.
Fixes #56436.
Fixes #56438.

Change-Id: Idcb96212a1d8c560e1dd8eaf7c80b6266f16431e
Reviewed-on: https://go-review.googlesource.com/c/go/+/445496
Reviewed-by: David Chase <[email protected]>
Run-TryBot: Russ Cox <[email protected]>
Reviewed-by: Roland Shoemaker <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
Auto-Submit: Russ Cox <[email protected]>
Reviewed-on: https://go-review.googlesource.com/c/go/+/445655
andrew-d pushed a commit to tailscale/go that referenced this issue Dec 7, 2022
@rsc @andrew-d
[release-branch.go1.19] crypto/x509: respect GODEBUG changes for allo…
ace82e4 
…wing SHA1 certificates

This allows programs that want SHA1 support to call os.Setenv at startup
instead of insisting that users set the environment variable themselves.

For golang#41682.
Fixes golang#56436.
Fixes golang#56438.

Change-Id: Idcb96212a1d8c560e1dd8eaf7c80b6266f16431e
Reviewed-on: https://go-review.googlesource.com/c/go/+/445496
Reviewed-by: David Chase <[email protected]>
Run-TryBot: Russ Cox <[email protected]>
Reviewed-by: Roland Shoemaker <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
Auto-Submit: Russ Cox <[email protected]>
Reviewed-on: https://go-review.googlesource.com/c/go/+/445655
@Revolyssup Revolyssup mentioned this issue Aug 2, 2023
Merged
@golang golang locked and limited conversation to collaborators Nov 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Projects
None yet
Milestone
Go1.19.4
Development

No branches or pull requests
2 participants
@gopherbot @heschi