-
-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Show approved (by me) Pull Requests #65
Labels
Comments
yushao2
added a commit
to yushao2/reviews
that referenced
this issue
May 2, 2021
yushao2
added a commit
to yushao2/reviews
that referenced
this issue
May 2, 2021
yushao2
added a commit
to yushao2/reviews
that referenced
this issue
May 2, 2021
yushao2
added a commit
to yushao2/reviews
that referenced
this issue
May 2, 2021
yushao2
added a commit
to yushao2/reviews
that referenced
this issue
May 2, 2021
yushao2
added a commit
to yushao2/reviews
that referenced
this issue
May 2, 2021
yushao2
added a commit
to yushao2/reviews
that referenced
this issue
May 2, 2021
yushao2
added a commit
to yushao2/reviews
that referenced
this issue
May 2, 2021
yushao2
added a commit
to yushao2/reviews
that referenced
this issue
May 2, 2021
yushao2
added a commit
to yushao2/reviews
that referenced
this issue
May 2, 2021
yushao2
added a commit
to yushao2/reviews
that referenced
this issue
May 2, 2021
yushao2
added a commit
to yushao2/reviews
that referenced
this issue
May 2, 2021
apoclyps
pushed a commit
that referenced
this issue
May 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Is your feature request related to a problem? Please describe.
I would like to see which pull requests have been approved by me and those approved by others.
This will replace the existing
status
column with 2 new columns.The first column
Approved
column should check if the pull request is approved by a user-provided via configuration.The second
Ready to Release
column should checkDescribe the solution you'd like
I would like to have a status column for
Approved
andReady to Release
.Additional context
Existing approved status is set here:
reviews/reviews/controller.py
Line 37 in 615ef9e
this will request changes to the
PullRequest
data class inreviews/reviews/datasource/models.py
Lines 13 to 22 in 615ef9e
A configurable user can be set via an environmental variable and used by defining it within:
reviews/reviews/config.py
Lines 16 to 24 in 615ef9e
The text was updated successfully, but these errors were encountered: