Feature #65 Show approved (by user) status #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yushao2
commented
May 2, 2021
apoclyps
reviewed
May 2, 2021
apoclyps
reviewed
May 2, 2021
yushao2
force-pushed
the
Feature-65
branch
2 times, most recently
from
b59e5ea to
fa9e930
Compare
|
Applied your suggestions! Thanks so much for your review and I've learnt quite a bit from your comments. Please take a look and let me know if there's anything else. |
apoclyps
approved these changes
May 2, 2021
There was a problem hiding this comment.
Everything look good 👍 I'm happy to hear you found the code review useful also. Thanks once again for your contributions.
If you are interested in working on any other areas of the code base, I'm happy for issues to be created (to discuss) or I can create more issues to choose from.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's Changed
Closes #65
Technical Description
Added new environment variable ,
GITHUB_USER-- this is to be initialised with the user's github username1.1. Updated README.md to reflect that during setup process
Renamed column Status > Approved
2.1. Shows Approved if user approved, and Changes Requested if user requested changes in PR (checks timestamp to grab latest status) -- Otherwise it is blank
Added new column, Ready To Release
3.1. Shows Ready if there are other approvals from other users, blanked otherwise.
3.2. Changed column spacing of PR title to avoid text cut-off for new column
Edited test cases due to change in schema for Pull Request model