-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: GraphQL execution for @defer
support
#413
Conversation
# Conflicts: # apollo-ios-codegen/Sources/GraphQLCompiler/ApolloCodegenFrontendBundle.swift
# Conflicts: # apollo-ios-codegen/Sources/GraphQLCompiler/JavaScript/src/__tests__/deferDirectiveTests.ts
Co-authored-by: Anthony Miller <[email protected]>
# Conflicts: # apollo-ios-codegen/Sources/ApolloCodegenLib/Templates/SelectionSetTemplate.swift
Co-authored-by: Anthony Miller <[email protected]>
# Conflicts: # apollo-ios-codegen/Sources/GraphQLCompiler/ApolloCodegenFrontendBundle.swift # apollo-ios/Sources/Apollo/FieldSelectionCollector.swift # apollo-ios/Sources/Apollo/GraphQLExecutor.swift # apollo-ios/Sources/Apollo/GraphQLSelectionSetMapper.swift
# Conflicts: # Tests/ApolloInternalTestHelpers/InterceptorTester.swift # apollo-ios/Sources/Apollo/DefaultInterceptorProvider.swift # apollo-ios/Sources/Apollo/GraphQLExecutor.swift # apollo-ios/Sources/Apollo/MultipartResponseDeferParser.swift # apollo-ios/Sources/Apollo/MultipartResponseParsingInterceptor.swift # apollo-ios/Sources/Apollo/MultipartResponseSubscriptionParser.swift
# Conflicts: # apollo-ios/Sources/Apollo/GraphQLResult.swift
# Conflicts: # apollo-ios-codegen/Sources/GraphQLCompiler/ApolloCodegenFrontendBundle.swift
✅ Deploy Preview for apollo-ios-docc canceled.
|
✅ Deploy Preview for eclectic-pie-88a2ba ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@defer
@defer
support
# Conflicts: # apollo-ios-codegen/Sources/GraphQLCompiler/ApolloCodegenFrontendBundle.swift
I'd like to provide feedback about the the way I would expect to be able to leverage the The ability to introspect the status of pseudo example taken from here
NOTE: I'd expect something similar with |
Hi @john-twigg-ck, thanks for the feedback.
The implementation of
There's only bad news here I'm afraid as unfortunately there is no existing support for |
b73d4bb8 feature: GraphQL execution for `@defer` support (#413) git-subtree-dir: apollo-ios git-subtree-split: b73d4bb836ec44ea3536d506b2a354eed9986ea7
… support git-subtree-dir: apollo-ios git-subtree-mainline: 7f6d97b git-subtree-split: b73d4bb836ec44ea3536d506b2a354eed9986ea7
90ab76be feature: GraphQL execution for `@defer` support (#413) git-subtree-dir: apollo-ios-codegen git-subtree-split: 90ab76bef1f2d2003b3825851ebb23999ca9846c
…`@defer` support git-subtree-dir: apollo-ios-codegen git-subtree-mainline: 6351b65 git-subtree-split: 90ab76bef1f2d2003b3825851ebb23999ca9846c
This PR is to merge the
@defer
required changes to the GraphQL executer intomain
. There is already some of the@defer
work in themain
branch but we chose to build the executor changes on a separate branch in isolation not to cause any instability tomain
.This PR should only consist of other PRs that have already been reviewed and merges from
main
to keep this branch up-to-date withmain
.