-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tracerLogger.submit is not a function #30
Comments
This should have been fixed by an earlier PR. We didn't publish a new version for that though. Will do so now. After an update this error should be gone. |
I have also got the error after make this correcton
|
You're saying you get this error with 0.1.5? @jbaxleyiii can you confirm? @whitecolor: Do you have a stack trace? And can you share how you are calling |
Yes update version 0.1.5
At least I get this error no this and trying access |
I'm assuming you get this error in the console on the server, but it still works and you get a response on the client, right? |
no, client sends error |
@whitecolor: Do you have a full stack trace on the server and/or the client? |
|
That is indeed the line I thought it was. I'm not sure why this works in our tests, but not in your code. Could you provide a minimal reproduction so I can run it and debug it myself? Doesn't even have to be minimal. Any reproduction I can reasonably set up and run in a few minutes will do. |
Have you tried do such thing:
and register apolloServer with such schema, then access graphiQL? |
I'm 99% sure that that's not the cause of the error you're observing, so I don't think it's worth trying. The easiest way for me to find out what's going on is if you could make a repo on GitHub and instructions for how to reproduce the error with the code in that repo. |
The easiest way for me is not make such mistake and don't get this error ;) |
@whitecolor any update on the reproduction? I would love to see one, so we can debug this. |
No, I think may be closed. If I will encounter and reproduce can be reopened then. |
Okay, thanks! |
Any progress on this? I get into the same problem in OSX using graphql-tools 0.4.2 but with nothing wrong in Windows. |
@whitecolor are you using OSX? |
@linonetwo which version of apollo-server are you using? Any code referring to tracer was removed in 0.2, afaik. |
@helfer Sorry for that, I was on client side graphQL server for too long, not knowing server side server has upgraded to apollo-server. After upgrading to apollo-server, everything is fine 👍 |
This reverts commits 0de2942, 97b3f68 and 293e28d. While the change in #3089 change was seemingly justified and straightforward (and as #3106 points out, perhaps _too_ straightforward! 😄), it seems that there was more to the change from `accept` to `@hapi/accept` and `boom` to `@hapi/boom` than just a name change. It seems that the packages may have dropped support for Node.js 6. While Node.js 6 is no longer supported by the Node Foundation, for semantic versioning reasons we weren't intending to completely drop support for it until Apollo Server 3.x. Maybe there's a more granular update here that maintains this support, but this update wasn't as simple as it would have seemed to be at face value (i.e. not a straight package rename of an otherwise internal dependency). Happy to consider re-landing a similar thing, but we need to make it more clear in the `CHANGELOG.md` and possibly reserve it for Apollo Server 3.x, but for now, should revert this to make sure we're not shipping a broken integration for Hapi users, as reported in #3106.
Trying apollo server.
Just got an error:
The text was updated successfully, but these errors were encountered: